Skip to content

Replace event string with constant#2128

Merged
jsnellbaker merged 1 commit intomasterfrom
improve-event-constants
Feb 9, 2018
Merged

Replace event string with constant#2128
jsnellbaker merged 1 commit intomasterfrom
improve-event-constants

Conversation

@matthewlane
Copy link
Collaborator

Type of change

  • Maintenance / Improvement

Description of change

  • Use const keyword for constants.json import
  • Replace individual event assignments with destructuring assignment
  • Replace hardcoded event string with equivalent constant

Other information

Resolves #2088

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit cfe1f72 into master Feb 9, 2018
@jsnellbaker jsnellbaker deleted the improve-event-constants branch February 9, 2018 13:34
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Feb 12, 2018
* 'master' of https://github.com/prebid/Prebid.js: (51 commits)
  Update maintainer email (prebid#2132)
  Replace event string with constant (prebid#2128)
  Add adapter for IAS (prebid#2056)
  Fix sovrn dealid (prebid#2119)
  Added support for NURL and ADM as backup (prebid#2112)
  fix bug where hooked functions w/ no hooks weren't ran immediately (prebid#2115)
  Increment pre version
  Prebid 1.3.1 Release
  Omit app and device if not present rather than send false (prebid#2116)
  Increment pre version
  Prebid.js 1.3.0 Release
  Unit test fixes (prebid#2111)
  must explicitly list pre1api for it to be included in build (prebid#2097)
  adkernel adapter additional bid parameters (prebid#2105)
  removing userSync (prebid#2032)
  33across Bid Adapter: Bugfix + Refactor (prebid#2024)
  Port calling order fix to 1.x  (prebid#2067)
  Update adform adapter request (prebid#2107)
  Serverbid Bid Adapter: getUserSyncs and new adsizes (prebid#2106)
  Add hfa and pv parameter to request payload (prebid#2109)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments