Add Invibes Adapter by rcheptanariu · Pull Request #2202 · prebid/Prebid.js

rcheptanariu · 2018-02-28T18:12:27Z

Type of change

New bidder adapter

Description of change

Added Invibes adapter to connect to Invibes for bids

test parameters for validating bids

{
  bidder: 'invibes',
  params: {
    placementId: '12345'
  }
}

contact email of the adapter’s maintainer: system_operations@invibes.com
official adapter submission
A link to a PR on the docs repo: Invibes Adapter - documentation prebid.github.io#638

jaiminpanchal27 · 2018-03-02T15:55:41Z

modules/invibesBidAdapter.js

+
+export const spec = {
+  code: CONSTANTS.BIDDER_CODE,
+  aliases: [CONSTANTS.BIDDER_CODE],


I see no reason to do this. It will replace your already registered adapter.

Sorry, I don't understand where the mistake is. If I don't export, my tests are failing because I can't import the spec. If I don't register the spec, my bidder is not called

@rcheptanariu I should have explained it in detail.
By adding aliases: [CONSTANTS.BIDDER_CODE], you are re-registering the adapter as you are using the same constant.
So you should remove the line aliases: [CONSTANTS.BIDDER_CODE] or use some different alias.

jaiminpanchal27 · 2018-03-02T20:19:45Z

modules/invibesBidAdapter.js

+  });
+
+  const topWin = getTopMostWindow();
+  var invibes = topWin.invibes = topWin.invibes || {};


Use let/const

jaiminpanchal27 · 2018-03-02T20:48:45Z

modules/invibesBidAdapter.js

+    .replace('creativeHtml', bidModel.CreativeHtml);
+}
+
+function getCappedCampaignsAsString() {


What is the purpose of this function ?

We have a campaign capping functionality that limits the amount of times the user should get an ad from the respective campaign, in a given time frame. An id is stored in localStorage, together with a view count and a timestamp.
That function returns a formatted parameter that we send from the adapter to our system to know if the campaign can be displayed again at the moment, to the current user.

jaiminpanchal27 · 2018-03-02T20:50:49Z

modules/invibesBidAdapter.js

+}
+
+/// Local domain cookie management =====================
+var Uid = {


Can you share how are you using these cookie functions and what is their purpose ?

ivNoCookie -> no cookies should be set for the user
ivbsdid -> a user id cookie. The entire 'Uid' +'initDomainId' is logic is for filtering (the user must return at least several times in multiple days. Else it is considered a temporary id and not sent with the bid request)
IvbsCampIdsLocal -> list of clicked campaign ids of the user
random test cookie -> to check for top cookie domain. We remove it afterwards

jaiminpanchal27 · 2018-03-02T20:53:10Z

modules/invibesBidAdapter.js

+        ttl: CONSTANTS.TIME_TO_LIVE,
+        ad: renderCreative(bidModel),
+
+        placementCode: bidRequest.placementCode


No need to add placementCode in bidResponse here.

jaiminpanchal27 · 2018-03-05T15:32:11Z

Also need a docs PR before merge. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

rcheptanariu · 2018-03-05T16:37:02Z

Docs PR at: prebid/prebid.github.io#638
Thank you!

rcheptanariu · 2018-03-06T11:10:33Z

Can you please confirm if the updates have been done as requested?
Thank you very much!

matthewlane · 2018-03-06T17:35:16Z

modules/invibesBidAdapter.js

+  const key = 'ivvcap';
+
+  let loadData = function () {
+    return JSON.parse(localStorage.getItem(key)) || {};


Any JSON.parse calls should be within a try/catch block

* 'master' of https://github.com/prebid/Prebid.js: (76 commits) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202) Increment pre version Prebid 1.5.0 Release Fix cross-platform test failures (prebid#2228) Fix uncahced video bids from multi-response array triggering callback early (prebid#2219) Add vuble adapter (prebid#2201) Update Vidazoo domain (prebid#2223) InSkin Bid Adapter: remove referrer field from request body (prebid#2217) Gamma Support UserSync Endpoint (prebid#2216) ...

* master: Audience Network: Add 'pbv' and 'cb' query params (prebid#2252) Add e-planning analytics adapter (prebid#2211) Add vastUrl for Gamma Adapter Video (prebid#2261) update params for test bid (prebid#2267) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202)

rcheptanariu added 9 commits February 6, 2018 17:21

Added invibes adapter

f55ed6c

added domain id & config

be257e9

invibes bid adapter - auction start and logging

a325024

invibes bid adapter refactor

4a9f5b7

Invibes Bid Adapter - renames

8e5a5d8

Invibes Bid Adapter - fix typo

92bb55f

Invibes Adapter - test spec

09101e7

Invibes Adapter - added size to test params

3441e51

Invibes Bid Adapter - lint fix

e6991c0

snapwich assigned snapwich and jaiminpanchal27 and unassigned snapwich Feb 28, 2018

Invibes Adapter - lint fix in test spec

b2df617

jaiminpanchal27 requested changes Mar 2, 2018

View reviewed changes

jaiminpanchal27 added the needs update label Mar 2, 2018

Invibes Bid Adapter - review change requests

b743be3

jaiminpanchal27 added the needs docs label Mar 5, 2018

Invibes Bid Adapter - remove alias according to review change requests

3563491

jaiminpanchal27 removed the needs docs label Mar 5, 2018

jaiminpanchal27 approved these changes Mar 6, 2018

View reviewed changes

jaiminpanchal27 added LGTM and removed needs update labels Mar 6, 2018

jaiminpanchal27 requested a review from matthewlane March 6, 2018 16:47

matthewlane requested changes Mar 6, 2018

View reviewed changes

matthewlane added needs update and removed LGTM labels Mar 6, 2018

Invibes Bid Adapter - review change request

150350a

matthewlane added LGTM and removed needs update labels Mar 7, 2018

matthewlane approved these changes Mar 7, 2018

View reviewed changes

matthewlane merged commit b0260d5 into prebid:master Mar 7, 2018

rcheptanariu mentioned this pull request Mar 8, 2018

Invibes Bid Adapter: adding to legacy branch #2240

Merged

1 task

Conversation

rcheptanariu commented Feb 28, 2018

Type of change

Description of change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 commented Mar 5, 2018

Uh oh!

rcheptanariu commented Mar 5, 2018

Uh oh!

rcheptanariu commented Mar 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments