PBS adapter not sending app or device#2206
Merged
mike-chowla merged 3 commits intomasterfrom Mar 8, 2018
Merged
Conversation
|
While testing my s2s fork, the error I was seeing was saying it needed either "app" or "page". I just pulled commit 428c125 , and, locally, added the one line change to also send page, which is what I need in my test scenario. This worked fine for me :
|
Contributor
Author
|
ready for review |
Contributor
Author
|
thanks @muncha - updated to include page |
Contributor
|
Code looks good. I'm a bit puzzled by the build failure for standard/object-curly-even-spacing since when I run lint locally on the PR, it passses |
Contributor
Author
|
yeah that is weird. I'll check into it |
Contributor
Author
|
not sure why my local lint wasn't picking up the bad style either. I fixed it so travis is happy now though. |
This was referenced Mar 8, 2018
|
Maybe it makes sense for the request that I made in #2243 to include vastUrl to be included with this? |
Contributor
|
Thank you @mike-chowla |
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Mar 15, 2018
* 'master' of https://github.com/prebid/Prebid.js: (76 commits) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202) Increment pre version Prebid 1.5.0 Release Fix cross-platform test failures (prebid#2228) Fix uncahced video bids from multi-response array triggering callback early (prebid#2219) Add vuble adapter (prebid#2201) Update Vidazoo domain (prebid#2223) InSkin Bid Adapter: remove referrer field from request body (prebid#2217) Gamma Support UserSync Endpoint (prebid#2216) ...
mizmaar3
added a commit
to widespace-os/Prebid.js
that referenced
this pull request
Mar 19, 2018
* master: Audience Network: Add 'pbv' and 'cb' query params (prebid#2252) Add e-planning analytics adapter (prebid#2211) Add vastUrl for Gamma Adapter Video (prebid#2261) update params for test bid (prebid#2267) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
s2sConfig.appands2sConfig.devicewere not getting picked up on either the legacy or new ORTB PBS endpoints. This fixes and adds tests.