Playground XYZ - new adapter#2606
Merged
jaiminpanchal27 merged 40 commits intoprebid:masterfrom Jun 7, 2018
Merged
Conversation
Merge from upstream
…8-prebidjs-pxyz-adapter
…8-prebidjs-pxyz-adapter
…8-prebidjs-pxyz-adapter
…ter-updated-upstream
Master updated upstream
…8-prebidjs-pxyz-adapter
…ter-updated-upstream
…8-prebidjs-pxyz-adapter
Master updated upstream
…8-prebidjs-pxyz-adapter
3648 prebidjs pxyz adapter
remove cpm logic from adapter
change application type to application\json for playground adapter
3648 prebidjs pxyz adapter
add extra space on error msg
jaiminpanchal27
approved these changes
Jun 5, 2018
Collaborator
jaiminpanchal27
left a comment
There was a problem hiding this comment.
@teranchristian LGTM. Just one thing
I think package-lock.json should not be in part of this PR.
Collaborator
|
Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
…into 3648-prebidjs-pxyz-adapter
3648 prebidjs pxyz adapter
Contributor
Author
|
Hi @jaiminpanchal27, thanks for reviewing our PR. I just removed the package-lock.json and added a minor change in the Overview (file .md). Also, we summited a PR to the docs repo and we are waiting for a fedback. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information