Skip to content

add docs for pgxyz#827

Merged
bretg merged 4 commits intoprebid:masterfrom
playground-xyz:pgxyz-docs
Jun 21, 2018
Merged

add docs for pgxyz#827
bretg merged 4 commits intoprebid:masterfrom
playground-xyz:pgxyz-docs

Conversation

@teranchristian
Copy link
Contributor

No description provided.

@bretg
Copy link
Contributor

bretg commented Jun 7, 2018

related to prebid/Prebid.js#2606

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately your adapter name is longer than 12 chars. If you can't change the name before releasing, please set this value to true.

Copy link
Contributor

@monofonik monofonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh @teranchristian our bidder code is longer than 12 characters!!

@monofonik
Copy link
Contributor

@bretg just saw your comment - what's the significance of the 12 character limit? Is it recommended to be 12 characters or less for some external constraints?

@bretg
Copy link
Contributor

bretg commented Jun 11, 2018

From http://prebid.org/dev-docs/publisher-api-reference.html#setConfig-Send-All-Bids

Important: DFP has a key-value key character limit of up to 20 characters. Some of the keys without truncation will exceed 20 chars. Prebid.js automatically truncates the key length to 20 characters. For example, hb_adid_longBidderName is truncated to hb_adid_longBidderNa (me is truncated). Note that the key is case-sensitive. To get the exact key-value keys for each bidder, find them at Bidder Params.

Prebid org uses the biddercode_longer_than_12 flag to lay out for users the targeting values they'll need to use in DFP. e.g. http://prebid.org/dev-docs/bidders.html#audienceNetwork

@teranchristian
Copy link
Contributor Author

hi @bretg thanks for the clarification. We just update the flag as requested

@teranchristian
Copy link
Contributor Author

@bretg we also enabled the support for GDPR in the docs.
Our implementation is already approved
prebid/Prebid.js#2699

@teranchristian
Copy link
Contributor Author

@bretg
I am just following up with a reminder that our docs is ready for review

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update

@bretg
Copy link
Contributor

bretg commented Jun 21, 2018

releases with 1.15

@bretg bretg merged commit 9a6d4f2 into prebid:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments