Rubicon able to read mediaTypes.size

[AntoineJac]

• Feature

Description of change

checkBidRequestSizes is normally present in adaptermanager.js to add the mediaTypes.banner.sizes to bid.sizes. However our adapter need to be able to read these fields in case the method is deprecated.
Same for the Video.

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[snapwich]

If params.sizes is present it should be used over both bid.sizes and mediaTypes.banner.sizes, so this logic needs to be adjusted.

[snapwich]

@idettman can you review this part to make sure this looks correct?

[snapwich]

please fix params.sizes to have highest priority.

[AntoineJac]

@snapwich , I have edited the change to first look at Rubicon size.

Thanks,

[snapwich]

LGTM

[idettman]

I discussed with Bobby, and the only issue is changing the second and third else if positions Line #526 and #528 so that banner sizes override bid sizes if present.
So Line 524 - 532 should be:

if (Array.isArray(params.sizes)) {
    sizes = params.sizes;
} else if (typeof utils.deepAccess(bid, 'mediaTypes.banner.sizes') !== 'undefined') {
    sizes = mapSizes(bid.mediaTypes.banner.sizes);
} else if (Array.isArray(bid.sizes) && bid.sizes.length > 0) {
    sizes = mapSizes(bid.sizes)
} else {
    utils.logWarn('Warning: no sizes are setup or found');
}

[AntoineJac]

@idettman,
I also agree that mediaTypes.banner.sizes that be look first.
I have just made the change and commit

Thanks,

[idettman]

LGTM