Set bid response ID to bid request ID#526
Merged
mkendall07 merged 2 commits intomasterfrom Aug 16, 2016
Merged
Conversation
Contributor
|
LGTM. |
protonate
pushed a commit
that referenced
this pull request
Aug 20, 2016
* Set bid response ID to bid request ID * Refactor
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update uses the new
bidfactory.createBidcapability of setting the bid response ID to match the bid request ID by passing the requested bid object as a second parameter.Also refactors status checking to remove redundant code and renames the bid map to clarify its purpose.