Merged
Conversation
added 2 commits
June 4, 2018 16:44
getTopWindowUrl error, it should be exports.function not this.function
Fix to pass FB test
harpere
reviewed
Jun 5, 2018
Collaborator
harpere
left a comment
There was a problem hiding this comment.
I don't really understand these changes. Is it just a FB test that needs this? or is there a real production problem? And under what circumstances does exports.getTopWindowLocation() work, but not this..getTopWindowLocation()?
Contributor
Author
|
As discussed I have edited to the correct behaviour and edit some change on Karma test for AudienceNetwork adapter. |
jaiminpanchal27
approved these changes
Jun 7, 2018
This was referenced Jun 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTopWindowUrl error, it should be exports.function not this.function
FB adapter is relying on this for getting the top location and for Postbid in Safeframe the referer is not passed. exports.getTopWindowLocation() should be used if this.getTopWindowLocation is not defined.
The FB JS test is made so pagueUrl must be void instead of returning the page (localhost for) or url format. That is why I was forced to do if (href.search(‘localhost/?‘) > 0) { href = ‘’; }
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information