Conversation
|
Hi @AntoineJac, this fix was made as part of prebid#2673 Since this repository is a fork of prebid/Prebid.js we want to keep it in sync with the upstream repository. That means we shouldn't be making pull-requests into rubicon-project/Prebid.js, only against prebid/Prebid.js so that we don't become out of sync. Those changes, once merged into prebid/Prebid.js, will come into rubicon-project/Prebid.js when we update our fork from the upstream. I'm going to reset our master branch against the upstream/master to put us back in sync. It will undo this commit you merged, but you should get the changes you wanted that were merged as part of prebid#2673 |
|
@snapwich , thanks Rich but I am pushing the change just on the local branch REA_0.34 that we use for the hosted prebid. Rhere is already a local fix for index on it. These fix won’t be sync with master as it is just for this branch and so we won’t be out of sync with prebid/Prebid.js. |
|
@AntoineJac oh okay, that should be fine. |
* add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (#22) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> * Remove trailing-space * Fix version in tests Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
prebid#6442) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (#22) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> * Remove trailing-space * Fix version in tests * sublimeAdapter: Improve pixels data * sublimeAdapter: Update tests * sublimeAdapter: Rename data Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com>
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information