Skip to content

Update utils.js#22

Merged
AntoineJac merged 1 commit intorelease/0.34.10-reafrom
FixTopWindow
Jun 8, 2018
Merged

Update utils.js#22
AntoineJac merged 1 commit intorelease/0.34.10-reafrom
FixTopWindow

Conversation

@AntoineJac
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@AntoineJac AntoineJac merged commit 1f3cd1c into release/0.34.10-rea Jun 8, 2018
@snapwich
Copy link

snapwich commented Jun 8, 2018

Hi @AntoineJac, this fix was made as part of prebid#2673

Since this repository is a fork of prebid/Prebid.js we want to keep it in sync with the upstream repository. That means we shouldn't be making pull-requests into rubicon-project/Prebid.js, only against prebid/Prebid.js so that we don't become out of sync. Those changes, once merged into prebid/Prebid.js, will come into rubicon-project/Prebid.js when we update our fork from the upstream.

I'm going to reset our master branch against the upstream/master to put us back in sync. It will undo this commit you merged, but you should get the changes you wanted that were merged as part of prebid#2673

@AntoineJac
Copy link
Author

@snapwich , thanks Rich but I am pushing the change just on the local branch REA_0.34 that we use for the hosted prebid. Rhere is already a local fix for index on it. These fix won’t be sync with master as it is just for this branch and so we won’t be out of sync with prebid/Prebid.js.

@snapwich
Copy link

snapwich commented Jun 8, 2018

@AntoineJac oh okay, that should be fine.

idettman pushed a commit that referenced this pull request Apr 23, 2020
* add prebid version of adapter

* Feature/update sublime adapter (#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (#22)

* add prebid version of adapter
* Feature/update sublime adapter (#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
idettman pushed a commit that referenced this pull request May 26, 2021
prebid#6442)

* add prebid version of adapter

* Feature/update sublime adapter (#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (#22)

* add prebid version of adapter
* Feature/update sublime adapter (#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

* sublimeAdapter: Improve pixels data

* sublimeAdapter: Update tests

* sublimeAdapter: Rename data

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com>
robertrmartinez pushed a commit that referenced this pull request Sep 16, 2021
* #22 Removing a/b logic and using result from server side

* #22 Better docs

* #22 Added a check in a test case

* fix typo

Co-authored-by: Marco Cosentino <mcosentino@id5.io>
Co-authored-by: Scott Menzer <scott@id5.io>
@robertrmartinez robertrmartinez deleted the FixTopWindow branch July 5, 2023 19:48
musikele pushed a commit that referenced this pull request Aug 28, 2023
* KargoBidAdapter: GPP Support

* kargo adapter to forward schain object (#21)

* wrap in if statement (#22)

* KRKPD-572: Add spec for schain (#23)

* wrap in if statement

* update test for schain, file formatting

---------

Co-authored-by: Jeremy Sadwith <jeremy@kargo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments