Rivr Analytics Adapter by AlessandroDG · Pull Request #3202 · prebid/Prebid.js

AlessandroDG · 2018-10-19T12:38:10Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

Add Rivr Analytics Adapter

bretg · 2018-10-22T18:11:03Z

Please consider making a docs pull request against https://github.com/prebid/prebid.github.io/blob/master/overview/analytics.md

AlessandroDG · 2018-10-24T13:32:32Z

You can find the PR with the suggested changes here: prebid/prebid.github.io#1013

AlessandroDG · 2018-10-24T14:34:45Z

@jsnellbaker I have one question. Should I buy a Browserstack plan or you are using the open source one?

mkendall07 · 2018-10-24T14:39:23Z

@AlessandroDG
You shouldn't need to purchase a browserstack license. I believe the issue here is that you must have a circleci account already associated with your github account. For some reason, instead of using prebid.js instance, it uses your instance which doesn't have access to the browserstack key. I'll reach out to circleci and see if there is a solution to this.

mkendall07 · 2018-10-24T14:43:04Z

if you want to test a quick workaround, perhaps fork prebid.js into your personal repo and then try opening the pull request from that repo...

AlessandroDG · 2018-10-24T14:54:59Z

@mkendall07 Thank you very much for the prompt reply.
I guess I will wait for your feedback, I would rather keep the PR flow consistent for traceability reasons in my company.

mkendall07 · 2018-10-24T15:07:16Z

no problem. I actually think you just need to restart the build from your end. I don't have access to do it - try clicking "re-run workflow" here: https://circleci.com/gh/simplaex/Prebid.js/13?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

AlessandroDG · 2018-10-24T15:49:41Z

I did it but I still get the same result

gulp test --browserstack
[15:45:24] Using gulpfile ~/Prebid.js/gulpfile.js
[15:45:24] Starting 'test'...
[15:45:24] Starting 'clean'...
[15:45:24] Finished 'clean' after 16 ms
[15:45:24] Starting 'lint'...
[15:45:39] Finished 'lint' after 15 s
[15:45:39] Starting 'test'...
24 10 2018 15:46:03.377:INFO [karma]: Karma v2.0.5 server started at http://0.0.0.0:9876/
24 10 2018 15:46:03.379:INFO [launcher]: Launching browsers bs_ie_14_windows_10, bs_ie_11_windows_10, bs_chrome_62_windows_10, bs_chrome_61_windows_10, bs_firefox_58_windows_10, bs_firefox_57_windows_10, bs_safari_9.1_mac_elcapitan, bs_safari_8_mac_yosemite with unlimited concurrency
BrowserStackTunnel: binary not present
24 10 2018 15:46:03.427:INFO [launcher]: Starting browser edge 14.0 (Windows 10) on BrowserStack
24 10 2018 15:46:03.427:INFO [launcher]: Starting browser ie 11.0 (Windows 10) on BrowserStack
24 10 2018 15:46:03.427:INFO [launcher]: Starting browser chrome 62.0 (Windows 10) on BrowserStack
24 10 2018 15:46:03.428:INFO [launcher]: Starting browser chrome 61.0 (Windows 10) on BrowserStack
24 10 2018 15:46:03.428:INFO [launcher]: Starting browser firefox 58.0 (Windows 10) on BrowserStack
24 10 2018 15:46:03.428:INFO [launcher]: Starting browser firefox 57.0 (Windows 10) on BrowserStack
24 10 2018 15:46:03.428:INFO [launcher]: Starting browser safari 9.1 (OS X El Capitan) on BrowserStack
24 10 2018 15:46:03.428:INFO [launcher]: Starting browser safari 8.0 (OS X Yosemite) on BrowserStack
BrowserStackTunnel: download binary for linux-x64 ...
Error: Automation testing time expired.
    at IncomingMessage.<anonymous> (/home/circleci/Prebid.js/node_modules/browserstack/lib/client.js:74:8)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:188:7)
    at endReadableNT (_stream_readable.js:975:12)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickDomainCallback (internal/process/next_tick.js:128:9)
BrowserStackTunnel: download complete
BrowserStackTunnel: chmod 0755 binary
24 10 2018 15:46:05.621:ERROR [launcher.browserstack]: Can not start chrome 62.0 (Windows 10)
  Error: Automation testing time expired.
24 10 2018 15:46:05.623:ERROR [launcher.browserstack]: Can not start ie 11.0 (Windows 10)
  Error: Automation testing time expired.
24 10 2018 15:46:05.635:ERROR [launcher.browserstack]: Can not start safari 8.0 (OS X Yosemite)
  Error: Automation testing time expired.
24 10 2018 15:46:05.642:ERROR [launcher.browserstack]: Can not start firefox 57.0 (Windows 10)
  Error: Automation testing time expired.
24 10 2018 15:46:05.649:ERROR [launcher.browserstack]: Can not start safari 9.1 (OS X El Capitan)
  Error: Automation testing time expired.
24 10 2018 15:46:05.652:ERROR [launcher.browserstack]: Can not start chrome 61.0 (Windows 10)
  Error: Automation testing time expired.
24 10 2018 15:46:05.654:ERROR [launcher.browserstack]: Can not start firefox 58.0 (Windows 10)
  Error: Automation testing time expired.
24 10 2018 15:46:05.680:ERROR [launcher.browserstack]: Can not start edge 14.0 (Windows 10)
  Error: Automation testing time expired.



[15:46:06] 'test' errored after 27 s
[15:46:06] Error: Karma tests failed with exit code 1
    at /home/circleci/Prebid.js/gulpfile.js:225:12
    at removeAllListeners (/home/circleci/Prebid.js/node_modules/karma/lib/server.js:334:9)
    at webServer.close (/home/circleci/Prebid.js/node_modules/karma/lib/server.js:344:11)
    at Server.close (net.js:1527:9)
    at Object.onceWrapper (events.js:293:19)
    at emitNone (events.js:91:20)
    at Server.emit (events.js:188:7)
    at emitCloseNT (net.js:1577:8)
    at _combinedTickCallback (internal/process/next_tick.js:77:11)
    at process._tickDomainCallback (internal/process/next_tick.js:128:9)
[15:46:06] 'test' errored after 42 s
Exited with code 1```

AlessandroDG · 2018-10-26T08:59:35Z

@mkendall07 did you receive any answer from circleci?

mkendall07 · 2018-10-26T14:34:38Z

I wasn't able to get any support because we are on a free plan. Can you try restarting the build one more time? It looks like it was successful previously looking at the PR history so perhaps I was mistaken on the missing keys

AlessandroDG · 2018-10-29T09:53:58Z

I executed it again and it fails in the same way.
I think the issue is not that keys are missing, it is that on the account I created on Browserstack I ran out of what they call "Automate Browser Testing" minutes.
For now I will create another account on Browserstack to get some more minutes.
If we won't be able to run circleci (and therefore Browserstack) on your account I think the only stable solution would be for us to have a paid plan on Browserstack. I would prefer to avoid it though, since I don't think we'll have more than a couple of PRs per month in the next months.

AlessandroDG · 2018-10-29T10:30:20Z

@mkendall07 I did what I mentioned in the previous comment and now the build is green again :)

jsnellbaker

See comment below. I encountered this while testing the analytics adapter.

jsnellbaker · 2018-10-31T15:18:39Z

modules/rivrAnalyticsAdapter.js

+
+function connectAllUnits(units) {
+  return units.reduce((acc, units) => {
+    units.forEach((unit) => acc.push(unit))


units in this line becomes an object at this point since it's inside the reduce; using forEach returns an error. Can you please review this area of the code?

Sure, thanks!

@jsnellbaker That function has been renamed to concatAllUnits() and I added a unit test to document what it does. The parameter units is an array of arrays [bannersArray, videosArray], therefore we were using reduce.
The implementation has actually been changed to a more elegant one.

Here the test https://github.com/prebid/Prebid.js/pull/3202/files#diff-d54f743aba4b5542eeab77162622bea9R468

…hing. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

…#9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

(cherry picked from commit 4def881)

Also removes undefined and null properties in audience events

…id#17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code

Use core-js includes function for array

* Submitting EMX Digital Adapter (prebid#3173) * Submitting EMX Digital Prebid Adapter Submitting EMX Digital Prebid Adapter code * fixing lint errors. updating our md * updating to const/let variables. adding test spec. * fixed linting on test spec js * TheMediaGrid Bid Adapter (prebid#3204) * Added Grid Bid Adapter * remove priceType from TheMediaGrid Bid Adapter * Adding user sync method for IFRAME and Pixel (prebid#3232) * Submitting EMX Digital Prebid Adapter Submitting EMX Digital Prebid Adapter code * fixing lint errors. updating our md * updating to const/let variables. adding test spec. * fixed linting on test spec js * adding emx usersync methods * updates (prebid#3162) * Only set native targeting if value exists. (prebid#3225) * add nolint command line option, similar to notest (prebid#3234) * add inskin iab vendor id: enables consent via string (prebid#3235) * Added user sync support for undertone bid adapter (prebid#3172) * Added user sync support for undertone bid adapter (new pull request) * Added user sync support for undertone bid adapter * fix indentation * Changed utils.getWindowTop() with the newer prebid utilities * Updating Auction Init Pick for timestamp + Test update (prebid#3223) * Updating Auction Init Pick for timestamp + Test update * Updating Auction Init to include once again + Rubicon Analytics update accordingly * Removing from auction init events in favor of old * Add code, test, and doc for Adikteev adapter (prebid#3229) * Add code, test, and doc for Adikteev adapter * Reflect comments on other PR http://prebid.org/dev-docs/bidder-adaptor.html#referrers prebid#3230 (comment) * 'currency' isn't a bidder-specific param Update PR following this remark on another one: prebid#3228 (comment) * Add integration example, fix bid requestId * Quantcast adapter onTimeout (prebid#3239) * onTimeout WIP * test for onTimeout * some renaming * cleanup * cleanup * trying to fix the test * using ajax instead of fetch * Test cleanup (prebid#3238) * stub pixel call in justpremium tests * properly stub geolocation services to prevent prompts * stub img creation as well to prevent call in justpremium * Appnexus adapter: Added dealPriority and dealCode to bidResponse (prebid#3201) * Added dealPriority and dealCode to appnexus adapter * update failed test * added namespace and did deep merge * keep all properties together * use unit id being sent instead of hard coded auid (prebid#3236) * use unit id being sent instead of hard coded auid * make multiple requests * removes commented out code. adds aus param back * Prebid 1.30.0 Release * increment pre version * fix deal targeting for cpm 0 (prebid#3233) * YIELDONE adapter - support Video (prebid#3227) * added UserSync * added UserSync Unit Test * support for multi sizes * register the adapter as supporting video * supporting video * change requestId acquisition method * fix the parameter name of dealID * update test parameters * support instream video * add test for bidRequest * add test for interpretResponse * add test params * add note to documentaion * clarifying the multi-format support message * rtbhouseBidAdapter changes (prebid#3241) * Add transactionId support * Change site getting method * Add bidfloor param * correct user agent value population (prebid#3248) * RVR-1124 Setup initial skeleton analytics adapter that can send something. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Formatted auction/events data to fit needed schema. * RVR-1135 fetched device data. * Applied feedback. * Applied feedback. * Fetched core. * Added click handler for reporting banners click events. * Applied analyzer for reporting displayed impressions. * Applied feedback. * Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7) RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1192-configuration-global-parameters (pull request #8) RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6) RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1247-additional-data-to-impression-records (pull request #9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1249-add-requestedbids-to-auction (pull request #10) RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1261-fix-tests (pull request prebid#11) RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * RVR-1352 analytics adapter bugs Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Fixed bug with geolocation notification. * fixed missing bracket. * one more fix. * RVR-1357 Different optimisation responses & tracking into auction event * RVR-1852 - Add content type and hardcoded auth headers (cherry picked from commit 4def881) * RVR-1852 - Change tracker host * RVR-1852 - Override content type instead of adding header * RVR-1914 Consistent data types in events Also removes undefined and null properties in audience events * Merged in RVR-1883-Add-Basic-Access-Authentication (pull request prebid#17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code * Increase code coverage * Fix for IE 11.0.0 and Safari 8.0.8 - includes() Use core-js includes function for array * Restore pbjs_api_spec.js * Fix API calls for rivr analytics impressions and clicks * RVR-2005 - Change auction object model * RVR-2005 - Set rvr_usr_id cookie * RVR-2005 - Remove BID_REQUESTED and BID_RESPONSE handlers We have the same infos all collected in AUCTION_END * RVR-2005 - build Bidders Array From Auction End * RVR-2005 - build impressions Array From Auction End * RVR-2005 - set status of winning bid * RVR-2005 - cleanup * RVR-2005 - adapt enableAnalytics() test * RVR-2005 - adapt all tests * RVR-2005 - Add Rivr Analytics adapter md file * RVR-2005 - rewrite connectAllUnits * RVR-2005 - correct typo * RVR-2005 - use IE compatible find()

* RVR-1124 Setup initial skeleton analytics adapter that can send something. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Formatted auction/events data to fit needed schema. * RVR-1135 fetched device data. * Applied feedback. * Applied feedback. * Fetched core. * Added click handler for reporting banners click events. * Applied analyzer for reporting displayed impressions. * Applied feedback. * Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7) RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1192-configuration-global-parameters (pull request #8) RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6) RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1247-additional-data-to-impression-records (pull request #9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1249-add-requestedbids-to-auction (pull request #10) RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1261-fix-tests (pull request #11) RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * RVR-1352 analytics adapter bugs Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Fixed bug with geolocation notification. * fixed missing bracket. * one more fix. * RVR-1357 Different optimisation responses & tracking into auction event * RVR-1852 - Add content type and hardcoded auth headers (cherry picked from commit 4def881) * RVR-1852 - Change tracker host * RVR-1852 - Override content type instead of adding header * RVR-1914 Consistent data types in events Also removes undefined and null properties in audience events * Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code * Increase code coverage * Fix for IE 11.0.0 and Safari 8.0.8 - includes() Use core-js includes function for array * Restore pbjs_api_spec.js * Fix API calls for rivr analytics impressions and clicks * Rvr 2005 rvr analytics adapter (#4) * Submitting EMX Digital Adapter (prebid#3173) * Submitting EMX Digital Prebid Adapter Submitting EMX Digital Prebid Adapter code * fixing lint errors. updating our md * updating to const/let variables. adding test spec. * fixed linting on test spec js * TheMediaGrid Bid Adapter (prebid#3204) * Added Grid Bid Adapter * remove priceType from TheMediaGrid Bid Adapter * Adding user sync method for IFRAME and Pixel (prebid#3232) * Submitting EMX Digital Prebid Adapter Submitting EMX Digital Prebid Adapter code * fixing lint errors. updating our md * updating to const/let variables. adding test spec. * fixed linting on test spec js * adding emx usersync methods * updates (prebid#3162) * Only set native targeting if value exists. (prebid#3225) * add nolint command line option, similar to notest (prebid#3234) * add inskin iab vendor id: enables consent via string (prebid#3235) * Added user sync support for undertone bid adapter (prebid#3172) * Added user sync support for undertone bid adapter (new pull request) * Added user sync support for undertone bid adapter * fix indentation * Changed utils.getWindowTop() with the newer prebid utilities * Updating Auction Init Pick for timestamp + Test update (prebid#3223) * Updating Auction Init Pick for timestamp + Test update * Updating Auction Init to include once again + Rubicon Analytics update accordingly * Removing from auction init events in favor of old * Add code, test, and doc for Adikteev adapter (prebid#3229) * Add code, test, and doc for Adikteev adapter * Reflect comments on other PR http://prebid.org/dev-docs/bidder-adaptor.html#referrers prebid#3230 (comment) * 'currency' isn't a bidder-specific param Update PR following this remark on another one: prebid#3228 (comment) * Add integration example, fix bid requestId * Quantcast adapter onTimeout (prebid#3239) * onTimeout WIP * test for onTimeout * some renaming * cleanup * cleanup * trying to fix the test * using ajax instead of fetch * Test cleanup (prebid#3238) * stub pixel call in justpremium tests * properly stub geolocation services to prevent prompts * stub img creation as well to prevent call in justpremium * Appnexus adapter: Added dealPriority and dealCode to bidResponse (prebid#3201) * Added dealPriority and dealCode to appnexus adapter * update failed test * added namespace and did deep merge * keep all properties together * use unit id being sent instead of hard coded auid (prebid#3236) * use unit id being sent instead of hard coded auid * make multiple requests * removes commented out code. adds aus param back * Prebid 1.30.0 Release * increment pre version * fix deal targeting for cpm 0 (prebid#3233) * YIELDONE adapter - support Video (prebid#3227) * added UserSync * added UserSync Unit Test * support for multi sizes * register the adapter as supporting video * supporting video * change requestId acquisition method * fix the parameter name of dealID * update test parameters * support instream video * add test for bidRequest * add test for interpretResponse * add test params * add note to documentaion * clarifying the multi-format support message * rtbhouseBidAdapter changes (prebid#3241) * Add transactionId support * Change site getting method * Add bidfloor param * correct user agent value population (prebid#3248) * RVR-1124 Setup initial skeleton analytics adapter that can send something. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Formatted auction/events data to fit needed schema. * RVR-1135 fetched device data. * Applied feedback. * Applied feedback. * Fetched core. * Added click handler for reporting banners click events. * Applied analyzer for reporting displayed impressions. * Applied feedback. * Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7) RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1192-configuration-global-parameters (pull request #8) RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6) RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1247-additional-data-to-impression-records (pull request #9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1249-add-requestedbids-to-auction (pull request #10) RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1261-fix-tests (pull request #11) RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * RVR-1352 analytics adapter bugs Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Fixed bug with geolocation notification. * fixed missing bracket. * one more fix. * RVR-1357 Different optimisation responses & tracking into auction event * RVR-1852 - Add content type and hardcoded auth headers (cherry picked from commit 4def881) * RVR-1852 - Change tracker host * RVR-1852 - Override content type instead of adding header * RVR-1914 Consistent data types in events Also removes undefined and null properties in audience events * Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code * Increase code coverage * Fix for IE 11.0.0 and Safari 8.0.8 - includes() Use core-js includes function for array * Restore pbjs_api_spec.js * Fix API calls for rivr analytics impressions and clicks * RVR-2005 - Change auction object model * RVR-2005 - Set rvr_usr_id cookie * RVR-2005 - Remove BID_REQUESTED and BID_RESPONSE handlers We have the same infos all collected in AUCTION_END * RVR-2005 - build Bidders Array From Auction End * RVR-2005 - build impressions Array From Auction End * RVR-2005 - set status of winning bid * RVR-2005 - cleanup * RVR-2005 - adapt enableAnalytics() test * RVR-2005 - adapt all tests * RVR-2005 - Add Rivr Analytics adapter md file * RVR-2005 - rewrite connectAllUnits * RVR-2005 - correct typo * RVR-2005 - use IE compatible find()

bretg requested a review from jsnellbaker October 22, 2018 18:09

bretg added the needs review label Oct 22, 2018

bretg assigned jsnellbaker Oct 22, 2018

AlessandroDG force-pushed the Rivr-Analytics-Adapter branch from 9430164 to a9dfc04 Compare October 24, 2018 13:49

jsnellbaker requested changes Oct 31, 2018

View reviewed changes

jsnellbaker added needs update and removed needs review labels Oct 31, 2018

Kacper Woźniak and others added 11 commits November 2, 2018 15:18

RVR-1124 Setup initial skeleton analytics adapter that can send somet…

6459aa5

…hing. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

Formatted auction/events data to fit needed schema.

0e28aca

Applied feedback.

1b6e487

RVR-1135 fetched device data.

e8aa2b8

Applied feedback.

0f0d7c7

Fetched core.

cc95453

Added click handler for reporting banners click events.

4701afe

Applied analyzer for reporting displayed impressions.

a6843a7

Applied feedback.

38197d8

Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7)

25f87f9

RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

Merged in RVR-1192-configuration-global-parameters (pull request #8)

337d998

RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

Kacper Woźniak and others added 19 commits November 2, 2018 15:18

Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6)

9c53d29

RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

Merged in RVR-1247-additional-data-to-impression-records (pull request …

71c81e1

…#9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

Merged in RVR-1249-add-requestedbids-to-auction (pull request #10)

0d78784

RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

RVR-1352 analytics adapter bugs

ccc1aaa

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>

Fixed bug with geolocation notification.

817c0e8

fixed missing bracket.

cf02bbc

one more fix.

710c1a4

RVR-1357 Different optimisation responses & tracking into auction event

4d5f827

RVR-1852 - Add content type and hardcoded auth headers

40d27ec

(cherry picked from commit 4def881)

RVR-1852 - Change tracker host

4f48bdd

RVR-1852 - Override content type instead of adding header

4e2eef7

RVR-1914 Consistent data types in events

6cdfbef

Also removes undefined and null properties in audience events

Increase code coverage

2260902

Fix for IE 11.0.0 and Safari 8.0.8 - includes()

215bc0f

Use core-js includes function for array

Restore pbjs_api_spec.js

144e212

Fix API calls for rivr analytics impressions and clicks

3fff417

AlessandroDG force-pushed the Rivr-Analytics-Adapter branch from 059a38b to ba19ef6 Compare November 2, 2018 14:21

jsnellbaker approved these changes Nov 5, 2018

View reviewed changes

jsnellbaker merged commit 432c656 into prebid:master Nov 5, 2018

AlessandroDG mentioned this pull request Dec 11, 2018

Rivr thin adapter #3351

Merged

9 tasks

Conversation

AlessandroDG commented Oct 19, 2018

Type of change

Description of change

Uh oh!

bretg commented Oct 22, 2018

Uh oh!

AlessandroDG commented Oct 24, 2018

Uh oh!

AlessandroDG commented Oct 24, 2018

Uh oh!

mkendall07 commented Oct 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkendall07 commented Oct 24, 2018

Uh oh!

AlessandroDG commented Oct 24, 2018

Uh oh!

mkendall07 commented Oct 24, 2018

Uh oh!

AlessandroDG commented Oct 24, 2018

Uh oh!

AlessandroDG commented Oct 26, 2018

Uh oh!

mkendall07 commented Oct 26, 2018

Uh oh!

AlessandroDG commented Oct 29, 2018

Uh oh!

AlessandroDG commented Oct 29, 2018

Uh oh!

jsnellbaker left a comment

Choose a reason for hiding this comment

Uh oh!

jsnellbaker Oct 31, 2018

Choose a reason for hiding this comment

Uh oh!

AlessandroDG Nov 1, 2018

Choose a reason for hiding this comment

Uh oh!

AlessandroDG Nov 2, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

mkendall07 commented Oct 24, 2018 •

edited

Loading