Rivr thin adapter

[AlessandroDG]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Delegates the events handling to an external component that Rivr will provide to publishers.

• contact email of the adapter’s maintainer: alessandro@simplaex.com

[jsnellbaker]

Hi @AlessandroDG

I'm not sure why this didn't run automatically with the PR, but I ran the browserstack tests locally to see how these changes would affect other browsers.

I saw a consistent test failure in IE11. Below is a copy of the test failure:

RIVR Analytics adapter
    �[31m✗ �[39m�[31menableAnalytics - should call rivraddon enableAnalytics with the correct arguments�[39m
	expected undefined to equal 'ExpiringQueue'
	Error
	   at AssertionError (webpack:///node_modules/assertion-error/index.js:74 <- test/test_index.js:21117:7)
	   at Assertion.prototype.assert (webpack:///node_modules/chai/lib/chai/assertion.js:107 <- test/test_index.js:29152:7)
	   at assertEqual (webpack:///node_modules/chai/lib/chai/core/assertions.js:487 <- test/test_index.js:29669:7)
	   at ctx[name] (webpack:///node_modules/chai/lib/chai/utils/addMethod.js:41 <- test/test_index.js:28739:5)
	   at Anonymous function (webpack:///test/spec/modules/rivrAnalyticsAdapter_spec.js:128:4 <- test/test_index.js:129303:6)

Could you take a look and correct the issue?

[AlessandroDG]

@jsnellbaker thank you for your feedback. I will run it locally too and apply the needed changes.

circleci/Browserstack configuration never really worked properly. In the previous PR I had a different issue. Your colleague tried to understand the cause but he couldn't because of the free plan you have with circleci.

Here you can find the conversation: #3202

[AlessandroDG]

@jsnellbaker browserstack tests ran now.

Anyway, I would really appreciate if you could help me figure out why the circleci build runs on our (Simplaex) instance rather then the Prebid one.

[jsnellbaker]

@AlessandroDG Thanks for making the updates.

In regards to the CircleCI job, I'm not 100% sure what to do here. From what we've seen, if the organization that houses the fork exists in CircleCI - it seems to default to run in that organization rather than in the target project. If you have any ideas here, please let us know.

[AlessandroDG]

@jsnellbaker Thanks for merging the PR.
And also for the input on CircleCI, I will investigate on our side and get back to you when I will find out something.