Skip to content

Fix import paths in adapters#3946

Merged
jsnellbaker merged 1 commit intoprebid:masterfrom
hashedhyphen:fix/adapter-import
Jun 26, 2019
Merged

Fix import paths in adapters#3946
jsnellbaker merged 1 commit intoprebid:masterfrom
hashedhyphen:fix/adapter-import

Conversation

@hashedhyphen
Copy link
Contributor

@hashedhyphen hashedhyphen commented Jun 26, 2019

Type of change

Bugfix

Description of change

This PR fixes issues when importing some adapters as npm dependencies.

Source:

import 'prebid.js/modules/open8BidAdapter';

Webpack's output:

ERROR in ./node_modules/prebid.js/modules/open8BidAdapter.js
Module not found: Error: Can't resolve 'src/utils' in '/path/to/node_modules/prebid.js/modules'
 @ ./node_modules/prebid.js/modules/open8BidAdapter.js 3:0-35 27:20-43 28:20-46 29:20-46 91:28-54 95:10-24 159:4-17

After this change, I confirmed npm test passed locally.

> npm test
...
Finished in 3.45 secs / 1.537 secs @ 18:39:56 GMT+0900 (GMT+09:00)

SUMMARY:
✔ 3959 tests completed
ℹ 1 test skipped
[18:39:56] Finished 'test' after 28 s
[18:39:56] Finished 'test' after 43 s

@jsnellbaker jsnellbaker self-requested a review June 26, 2019 12:43
@jsnellbaker jsnellbaker self-assigned this Jun 26, 2019
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hashedhyphen Thanks for putting this together.

@jsnellbaker jsnellbaker merged commit 6e02649 into prebid:master Jun 26, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments