Reload Adapter & Spec: Added GDPR and multiple sizes#3967
Reload Adapter & Spec: Added GDPR and multiple sizes#3967mike-chowla merged 8 commits intoprebid:masterfrom
Conversation
|
This pull request introduces 1 alert when merging 14dc0dc into b02a00c - view on LGTM.com new alerts:
This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
modules/reloadBidAdapter.js
Outdated
| registerBidder | ||
| } | ||
| from '../src/adapters/bidderFactory'; | ||
| from 'src/adapters/bidderFactory'; |
modules/reloadBidAdapter.js
Outdated
| }; | ||
|
|
||
| function _genWinInfo () { | ||
| function getBestLocInf() { |
There was a problem hiding this comment.
You should using bidderRequest.refererInfo rather than tyring to find the top window yourself
http://prebid.org/dev-docs/bidder-adaptor.html#bidrequest-parameters
There was a problem hiding this comment.
@mike-chowla Hello Mike, we tried to use your suggestion but it is not possible. We use a single module ('ReloadClientTool') that acts as a common interface across all our adapters, so we cannot use features of any specific wrapper within that class. We explained this to Jaimin in relation to our original version (see #3812).
|
@mike-chowla Hello Mike, we have decided to modify our code elsewhere to meet your request. You will notice some changes in the interface class in that sense. Since this sits on our critical path, we would very much appreciate if this could be included in next-week’s release. Thanks! |
|
@mike-chowla Mike, we have included a last-minute modification to make use of the method “onBidWon”. Everything else has not changed. |
|
One last modification required for backward compatibility. Thnx! |
* Reload Adapter & Spec: Added GDPR and multiple sizes * Reload Adapter - Fixed LGTM alert * Reload Adapter - Fixed import (path relative) * Reload Adapter: Read values from refererInfo and utils class. * Reload Adapter - Added onBidWon * Reload Adapter - Changed attribute's name * Reload Adapter - Backward Compatibility * Reload Adapter - Backward compatibility
* Reload Adapter & Spec: Added GDPR and multiple sizes * Reload Adapter - Fixed LGTM alert * Reload Adapter - Fixed import (path relative) * Reload Adapter: Read values from refererInfo and utils class. * Reload Adapter - Added onBidWon * Reload Adapter - Changed attribute's name * Reload Adapter - Backward Compatibility * Reload Adapter - Backward compatibility
3 participants
Type of change
Description of change
contact email of the adapter’s maintainer: prebid@reload.net