Conversation
# Conflicts: # integrationExamples/gpt/userId_example.html # test/spec/modules/userId_spec.js
# Conflicts: # modules/userId/index.js
idettman
left a comment
idettman
left a comment
There was a problem hiding this comment.
Change the submodule registration so that it is handled in the identityLinkSubmodule, not in userId/index.js
modules/userId/index.js
Outdated
| // add submodules after init has been called | ||
| attachIdSystem(pubCommonIdSubmodule); | ||
| attachIdSystem(unifiedIdSubmodule); | ||
| attachIdSystem(identityLinkSubmodule); |
There was a problem hiding this comment.
The attachIdSystem should be used in the file identityLinkSystem.js, the unifiedId and pubComonId are the only submodules included by default, and they will also be optional starting with Prebid 3.0.
Look at the code for ID5 Submodule as an example.
Specifically, lines 10 and 60 are responsible for registering the submodule with the user id module.
There was a problem hiding this comment.
Hi @idettman,
Thank you for the explanation. I'm changed implementation of identityLink submodule as you suggested. Follow the code in ID5 Submodule...
|
Also, conflicts need resolution |
idettman
added
needs 2nd review
modules/userId/index.js
Outdated
| import {module} from '../../src/hook'; | ||
| import {unifiedIdSubmodule} from './unifiedIdSystem.js'; | ||
| import {pubCommonIdSubmodule} from './pubCommonIdSystem.js'; | ||
| import {identityLinkSubmodule} from './identityLinkSystem.js'; |
There was a problem hiding this comment.
Remove the import for identityLinkSubmodule - the identity link submodule handles the registering in it’s submodule js.
idettman
added
LGTM
and removed
needs 2nd review
* idLink - integrate new submodule idLinkSystem in to userId module * idLink - Fix unit tests * identityLink - Change submodule name from idLink to identityLink * Identity Link - Remove identity link to be default submodule
* idLink - integrate new submodule idLinkSystem in to userId module * idLink - Fix unit tests * identityLink - Change submodule name from idLink to identityLink * Identity Link - Remove identity link to be default submodule
* idLink - integrate new submodule idLinkSystem in to userId module * idLink - Fix unit tests * identityLink - Change submodule name from idLink to identityLink * Identity Link - Remove identity link to be default submodule
2 participants
Type of change
Description of change
Add Identity Link submodule in module userId to fetch user’s identity link envelope and add it to the bid request. It is very similar to other userId submodule like Id5id and unifiedID.
A link to a PR on the docs repo at Integrate id link system prebid.github.io#1377