Skip to content

Integrate id link system#1377

Merged
bretg merged 7 commits intoprebid:masterfrom
mamatic:Integrate_Id_Link_System
Aug 21, 2019
Merged

Integrate id link system#1377
bretg merged 7 commits intoprebid:masterfrom
mamatic:Integrate_Id_Link_System

Conversation

@mamatic
Copy link
Contributor

@mamatic mamatic commented Jul 4, 2019

Add documentation and examples for Identity Link submodule.

# Conflicts:
#	dev-docs/modules/userId.md
@mamatic
Copy link
Contributor Author

mamatic commented Jul 24, 2019

Hi @idettman ,
can you please review or assign someone to this PR?

Thanks in advance!

@ian-lr
Copy link
Contributor

ian-lr commented Aug 5, 2019

@bretg @idettman Are you able to review? Thank you!

@bretg
Copy link
Contributor

bretg commented Aug 16, 2019

Sorry - was on vacation. I tweaked the docs a bit. Please make sure you're happy with it. The tag lines on top were getting unwieldy, so evolving them towards more of a 'marketing' tagline.

And sorry again, but I don't like the name of the file created for this module in the Prebid.js repo. It's currently identityLinkSystem.js, but all others have the suffix *IdSystem.js

I'd like PR #4077 to change the filename in the Prebid.js repo to identityLinkIdSystem.js, or pubs and managed services will typo this inconsistency frequently.

@mamatic
Copy link
Contributor Author

mamatic commented Aug 16, 2019

Hi @bretg,
the changes are ok. Thanks for that :)

@mamatic
Copy link
Contributor Author

mamatic commented Aug 21, 2019

Hi @bretg ,
pull request on code repo is merged:
prebid/Prebid.js#4077
If everything is ok can you please merge this one?
Thanks in advance

@bretg bretg removed the question label Aug 21, 2019
@bretg bretg merged commit 5111fe9 into prebid:master Aug 21, 2019
@bretg
Copy link
Contributor

bretg commented Aug 21, 2019

went out with 2.29

@bretg
Copy link
Contributor

bretg commented Sep 20, 2019

@mamatic -

Just noticed that a couple of user ID sub-modules aren't being passed through Prebid Server calls, Identity Link being one of them. How would you like it passed through user.ext.eids? e.g.

{
                "source": "identityLink",
                "uids": [{
                    "id": "11111111"
                }]
            }

@ian-lr
Copy link
Contributor

ian-lr commented Sep 25, 2019

Hey @bretg, can we pass it as:

{
      "source": "liveramp.com",
      "uids": [
        {
          "id": "11111111",
          "ext": {
            "rtiPartner": "idl"
          }
        }
      ]
    }

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments