Merged
Conversation
Collaborator
|
Thanks for the PR, assigned for review. |
protonate
suggested changes
Oct 24, 2016
Collaborator
protonate
left a comment
protonate
left a comment
There was a problem hiding this comment.
Thank you, code looks good. I am not getting ads to render however. Some debugging found that the ID is not passed back in the server response. I'll post two screenshots that illustrate this. Please resolve the ad render for this branch and we can merge.
| OpenRTBRequest.prototype.serialize = function () { | ||
| var json = '{"id":' + this.requestID + ',"site":{"page":"' + quote(this.sitePage) + '"'; | ||
| if (typeof document.referrer === 'string') { | ||
| var json = '{"id":"' + this.requestID + '","site":{"page":"' + quote(this.sitePage) + '"'; |
Collaborator
There was a problem hiding this comment.
ES6 Template Literals are also an option, e.g.:
var json = `{"id":"${this.requestID}", "site": { "page": "${quote(this.sitePage)}"`;
protonate
reviewed
Oct 24, 2016
|
|
||
| assert.isUndefined( adLoader.loadScript.firstCall.args[0], "no request made to AS"); | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Many thanks for the additional test coverage.
Collaborator
No ID in response (topic branch)This shows the topic branch response, you'll see the ID highlighted in the address bar and on the last line of the response (at the bottom) the ID is null.
ID in response (master branch)This ad renders and the ID is contained in the response.
|
Contributor
Author
@protonate The issue is resolved from the sandbox server; no adapter code change required. |
protonate
approved these changes
Oct 25, 2016
Collaborator
|
Thanks @indexexchange, merged. |
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…ebid-0.14.0 to release/1.7.0 * commit '3eefcf043466f5457c81bfec18b032b53490b78b': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…7.0 to master * commit '262f371a5c855419c3ef357fb1f0cf87a107749f': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The change includes following:
Other information