Show warning if bidCpmAdjustment is set for AOL bidder (closes #725)#728
Merged
mkendall07 merged 3 commits intoprebid:masterfrom Oct 26, 2016
Merged
Conversation
Contributor
|
Can we make sure this only running in debug mode and not production? Some of us use adjustments for things other than rev shares. |
Member
Author
Contributor
|
@marian-r |
- fix after implementation changed from console.warn to utils.logWarn
Member
Author
|
Ah, of course. Sorry, I forgot to update the unit test. It's fixed in 107f419. |
Contributor
|
LGTM. |
9 tasks
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…ebid-0.14.0 to release/1.7.0 * commit '3eefcf043466f5457c81bfec18b032b53490b78b': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…7.0 to master * commit '262f371a5c855419c3ef357fb1f0cf87a107749f': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
pm-abhinav-deshpande
pushed a commit
to pm-abhinav-deshpande/Prebid.js
that referenced
this pull request
Apr 23, 2025
Added the entries for arcspan RTC provider and sizemapping v2 module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
After the recent update of AOL adapter made in #653, the bid price adjustment is not recommended on the client side and it has been moved onto backend. In the PR I suggested a note to be included in the release notes, but I expect that can be not enough and some publishers may over look that.
This PR adds a warning in the console if the publisher has configured bidCpmAdjustment as discussed in #725. It will help publishers to be aware of the change introduced in the upcoming version.
I did not use utils.logWarn() method as it is better to show this warning regardless of whether the debug mode is on or off.