Make sure AUCTION_END event is dispatched before BID_WON event in a post-bid scenario.#852
Closed
mp-12301 wants to merge 1 commit intoprebid:masterfrom
Closed
Make sure AUCTION_END event is dispatched before BID_WON event in a post-bid scenario.#852mp-12301 wants to merge 1 commit intoprebid:masterfrom
mp-12301 wants to merge 1 commit intoprebid:masterfrom
Conversation
mkendall07
reviewed
Dec 5, 2016
|
|
||
| //execute one time callback | ||
| if (externalCallbacks.oneTime) { | ||
| $$PREBID_GLOBAL$$.clearAuction(); |
Contributor
There was a problem hiding this comment.
We may have some timing issues with moving this up. @protonate to review
Contributor
Author
|
Hey guys any update on this? |
Collaborator
|
Actually AUCTION_END is intended to fire after BID_WON events. I apologize for not catching this sooner. As it is the Perhaps what is wanted is an AUCTION_CLOSED event which could be emitted at the top of |
Collaborator
|
See #884 for possible solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updated to have the AUCTION_END event dispatched before BID_WON event in a post-bid scenario where
pbjs.renderAdis called inside thepbjs.requestBidshandler.Other information
#797