Skip to content

emit AUCTION_END event before bidsBackHandler callback#884

Merged
mkendall07 merged 1 commit intomasterfrom
maintenance/move-auction-end-event
Dec 16, 2016
Merged

emit AUCTION_END event before bidsBackHandler callback#884
mkendall07 merged 1 commit intomasterfrom
maintenance/move-auction-end-event

Conversation

@protonate
Copy link
Collaborator

Type of change

  • Other

Description of change

Emit the AUCTION_END event sooner, before the bidsBackHandler is called when closing an auction.

@protonate protonate changed the title emit auction end event before bidsBackHandler callback emit AUCTION_END event before bidsBackHandler callback Dec 16, 2016
@protonate
Copy link
Collaborator Author

cc: mpereira96 @marian-r

@mp-12301
Copy link
Contributor

Looks good guys, thank you.

@mkendall07
Copy link
Contributor

LGTM. Thanks @protonate

@mkendall07 mkendall07 merged commit 6953fe3 into master Dec 16, 2016
@mkendall07 mkendall07 deleted the maintenance/move-auction-end-event branch January 10, 2017 15:10
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…ebid-official-0.17.0 to release/1.12.0

* commit 'bce975978c2c088d301d120b949d38080ca9d314':
  Add changelog entry.
  Prebid Release 0.17.0
  remove hb_pb targeting key for deal bids with no cpm (prebid#881)
  Fix for bug prebid#866 (prebid#867)
  Allow changing of 'ga' global variable (prebid#832)
  emit auction end event before bidsBackHandler callback (prebid#884)
  Add Widespace adapter (prebid#846)
  prevent rubicon adapter from registering two bids on exceptions (prebid#854)
  Code Refactoring - Upgrading end point. (prebid#826)
  Ignore test html pages (prebid#878)
  Detect browser width instead of the screen width (prebid#837)
  New aardvark adapter with support for aliasing (prebid#875)
  Add Fidelity adapter (prebid#862)
  Adkernel adapter aliasing (prebid#857)
  0.16.1-pre
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…12.0 to master

* commit '728f1763ce2a282a757546e934199313a4771a21':
  Fix failing unit test on CI.
  Add changelog entry.
  Prebid Release 0.17.0
  remove hb_pb targeting key for deal bids with no cpm (prebid#881)
  Fix for bug prebid#866 (prebid#867)
  Allow changing of 'ga' global variable (prebid#832)
  emit auction end event before bidsBackHandler callback (prebid#884)
  Add Widespace adapter (prebid#846)
  prevent rubicon adapter from registering two bids on exceptions (prebid#854)
  Code Refactoring - Upgrading end point. (prebid#826)
  Ignore test html pages (prebid#878)
  Detect browser width instead of the screen width (prebid#837)
  New aardvark adapter with support for aliasing (prebid#875)
  Add Fidelity adapter (prebid#862)
  Adkernel adapter aliasing (prebid#857)
  0.16.1-pre
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments