Feature/widespace adapter by jonasmattsson1 · Pull Request #846 · prebid/Prebid.js

jonasmattsson1 · 2016-12-02T08:21:29Z

Type of change

Description of change

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

contact email of the adapter’s maintainer
official adapter submission

Other information

jonasmattsson1 · 2016-12-02T08:23:25Z

The contact email of the adapter’s maintainer:
jonas.mattsson@widespace.com

matthewlane

Thanks for the new adapter PR. Please add your adapter to the adapters.json file and update your tests to pass. See this page for information about testing Prebid.js if needed, thanks

matthewlane · 2016-12-05T17:53:44Z

test/spec/adapters/widespace_spec.js

+  }
+
+  beforeEach(() => {
+    pbjs._bidsRequested = [];


This causes several other unit tests to fail

matthewlane

Please update according to the notes below.

Also, are these bidder params still valid for testing?

{
  bidder: 'widespace',
  params: {
    sid: 'f666bfaf-69cf-4ed9-9262-08247bb274e4',
    cur: 'EUR'
  }
}

I'm not getting bids back with them.

matthewlane · 2016-12-07T19:29:10Z

adapters.json

    "centro",
    "roxot",
    "vertoz",
+    'widespace',


JSON requires double quotes, please use them here

Fixed, thank you

matthewlane · 2016-12-07T19:30:33Z

test/spec/adapters/widespace_spec.js

+  let sandbox;
+
+  beforeEach(() => {
+    pbjs._bidsRequested = [];


This can cause other test to fail, please remove

Fixed, thank you

matthewlane · 2016-12-07T19:31:16Z

test/spec/adapters/widespace_spec.js

+      pbjs._bidsRequested.push(BID_REQUEST);
+      pbjs.widespaceHandleCB(BID_RESPONSE);
+
+      console.log(bidManager.addBidResponse.firstCall.args[0]);


Please remove console.log statements from tests

Removed, thank you

matthewlane · 2016-12-07T19:31:22Z

test/spec/adapters/widespace_spec.js

+    });
+
+    it('should use the CPM returned by the server', () => {
+      console.log('successfulBid1', successfulBid1);


Removed, thank you

matthewlane · 2016-12-07T19:31:27Z

test/spec/adapters/widespace_spec.js

+
+    it('should use the CPM returned by the server', () => {
+      console.log('successfulBid1', successfulBid1);
+      console.log('successfulBid1 CPM :::', successfulBid1.cpm);


Removed, thank you

matthewlane · 2016-12-07T19:39:48Z

test/spec/adapters/widespace_spec.js

+
+  describe('respond with a successful bid', () => {
+    let successfulBid1,
+        placementCode;


This variable is never used, please remove if you don't need it

Removed, thank you

jonasmattsson1 · 2016-12-08T12:52:35Z

Thank you, I have updated the tests.

You should now receive test ad´s with
{ bidder: 'widespace', params: { sid: 'f666bfaf-69cf-4ed9-9262-08247bb274e4', cur: 'EUR' } }

matthewlane · 2016-12-12T18:16:51Z

Changes look good and tests pass. I'm still getting back noad status responses with those params though, any pointers? Once I can verify a valid status response we should be good to merge

…00 ad sizes.

jonasmattsson1 · 2016-12-13T09:12:54Z

Hi,

I think you get status = 'noad' because we don´t have 300x250 or 300x600 ad sizes in our system.
I added [300,300] to adunit.sizes. Hope that is okey.

Thank you,
Jonas

matthewlane · 2016-12-13T18:22:53Z

Hmm, even with size [300, 300], still seeing a noad response. Could it be a referrer problem? Anything else I need to check for?

jonasmattsson1 · 2016-12-15T13:12:00Z

Hi, Can you try to emulate a mobile like iPhone in Chrome forexample.
It´s probably that I think, We only serve ad´s to mobile devices.

matthewlane · 2016-12-15T21:48:39Z

No luck with an iPhone or Chrome on mobile for me. Here's a test page I've set up http://client-test.devnxs.net/widespace/. This is using prebid.js built with your adapter. Currently I'm seeing

available:  []
empty or error:  ["widespace"]

in the dev console. For review I check if the adapter is showing up in the available category. Can you check this page as well? Let me know if you are getting a different result, if the params I'm using on the html in that page look wrong, etc. Hopefully this can help track down why I'm not seeing bids. Thanks!

jonasmattsson1 · 2016-12-16T08:55:48Z

Thank you for the time to set up the test page. I got noad on your test page aswell but
I see that you are using widespace param sid = "f666bfaf-69cf-4ed9-9262-08247bb274e4", It should be sid = "7b6589bf-95c8-4656-90b9-af9737bb9ad3" that are linked to a demo account.

I get ad´s on your page when I rewrite the sid parameter to the right one in Charles, see the print screen that I made.

https://drive.google.com/file/d/0B2Hq0o69IghYRS0yTXU0eUJ4dEU/view?usp=sharing
You still need to emulate an mobile device.

Thank you,
Jonas

matthewlane · 2016-12-16T17:44:26Z

Getting bids now with "7b6589bf-95c8-4656-90b9-af9737bb9ad3" and mobile emulation, thanks

…ebid-official-0.17.0 to release/1.12.0 * commit 'bce975978c2c088d301d120b949d38080ca9d314': Add changelog entry. Prebid Release 0.17.0 remove hb_pb targeting key for deal bids with no cpm (prebid#881) Fix for bug prebid#866 (prebid#867) Allow changing of 'ga' global variable (prebid#832) emit auction end event before bidsBackHandler callback (prebid#884) Add Widespace adapter (prebid#846) prevent rubicon adapter from registering two bids on exceptions (prebid#854) Code Refactoring - Upgrading end point. (prebid#826) Ignore test html pages (prebid#878) Detect browser width instead of the screen width (prebid#837) New aardvark adapter with support for aliasing (prebid#875) Add Fidelity adapter (prebid#862) Adkernel adapter aliasing (prebid#857) 0.16.1-pre

…12.0 to master * commit '728f1763ce2a282a757546e934199313a4771a21': Fix failing unit test on CI. Add changelog entry. Prebid Release 0.17.0 remove hb_pb targeting key for deal bids with no cpm (prebid#881) Fix for bug prebid#866 (prebid#867) Allow changing of 'ga' global variable (prebid#832) emit auction end event before bidsBackHandler callback (prebid#884) Add Widespace adapter (prebid#846) prevent rubicon adapter from registering two bids on exceptions (prebid#854) Code Refactoring - Upgrading end point. (prebid#826) Ignore test html pages (prebid#878) Detect browser width instead of the screen width (prebid#837) New aardvark adapter with support for aliasing (prebid#875) Add Fidelity adapter (prebid#862) Adkernel adapter aliasing (prebid#857) 0.16.1-pre

jonasmattsson1 added 2 commits December 1, 2016 10:12

Widespace adapter

dad3732

Widespace adapter tests

9b93658

matthewlane requested changes Dec 5, 2016

View reviewed changes

matthewlane added the needs update label Dec 5, 2016

jonasmattsson1 added 2 commits December 7, 2016 16:48

Tests are passing

0324ac9

Added widespace to adaptors.json

bbea267

matthewlane self-assigned this Dec 7, 2016

matthewlane requested changes Dec 7, 2016

View reviewed changes

jonasmattsson1 added 4 commits December 8, 2016 09:12

Should be double quotes

295b411

Removed debug log

e66b6b6

Updated Wdespace test with a sid parameter that will receive test ad´s.

29f5df7

Updated tests

1e08943

Dont reset pbjs._bidsRequested beforeEach

badfbdb

matthewlane removed the needs update label Dec 12, 2016

I added 300x300 to allowed ad sizes as we don't have 300x250 or 300x6…

84ae0b2

…00 ad sizes.

matthewlane approved these changes Dec 16, 2016

View reviewed changes

matthewlane merged commit d6ebd87 into prebid:master Dec 16, 2016

Conversation

jonasmattsson1 commented Dec 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

jonasmattsson1 commented Dec 2, 2016

Uh oh!

matthewlane left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthewlane left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonasmattsson1 commented Dec 8, 2016

Uh oh!

matthewlane commented Dec 12, 2016

Uh oh!

jonasmattsson1 commented Dec 13, 2016

Uh oh!

matthewlane commented Dec 13, 2016

Uh oh!

jonasmattsson1 commented Dec 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthewlane commented Dec 15, 2016

Uh oh!

jonasmattsson1 commented Dec 16, 2016

Uh oh!

matthewlane commented Dec 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

jonasmattsson1 commented Dec 2, 2016 •

edited

Loading

jonasmattsson1 commented Dec 15, 2016 •

edited

Loading