Conversation
matthewlane
assigned
matthewlane and
protonate and unassigned
protonate and
matthewlane
protonate
left a comment
protonate
left a comment
There was a problem hiding this comment.
LGTM, tests pass and ads are returned, reviewed.
|
Is it normal behavior for Index to return multiple bids per slot? Additionally, I am seeing a situation where Index returns multiple bids per slot, and the higher bid is submitted with hb_pb etc. keys, and the lower bid is passed in through the hb_pb_indexexchange key. Thus, the lower bid is sent to the DFP auction. I saw the behavior happening on this site: http://bit.ly/2nt0A9Q; prebid.js: 0.19.0; Google Chrome 56.0.2924.87 |
|
It is expected in cases for multi-size ad units as IX makes a request per size. The highest IX bid should always be set as auction winner keys when IX wins. As for the bid landscape keys, I'm not sure that those keys would always be the second lower bid. |
|
Ok thanks for confirming they send multiple bids. The client is using "Send All Bids". I'd expect if an IX bid wins, it should be inserted for auction winner keys and bid landscape keys, since the bid landscape keys are targeted by Index specific DFP line items, but that didn't seem to always be the case. |
…ebid-official-0.17.0 to release/1.12.0 * commit 'bce975978c2c088d301d120b949d38080ca9d314': Add changelog entry. Prebid Release 0.17.0 remove hb_pb targeting key for deal bids with no cpm (prebid#881) Fix for bug prebid#866 (prebid#867) Allow changing of 'ga' global variable (prebid#832) emit auction end event before bidsBackHandler callback (prebid#884) Add Widespace adapter (prebid#846) prevent rubicon adapter from registering two bids on exceptions (prebid#854) Code Refactoring - Upgrading end point. (prebid#826) Ignore test html pages (prebid#878) Detect browser width instead of the screen width (prebid#837) New aardvark adapter with support for aliasing (prebid#875) Add Fidelity adapter (prebid#862) Adkernel adapter aliasing (prebid#857) 0.16.1-pre
…12.0 to master * commit '728f1763ce2a282a757546e934199313a4771a21': Fix failing unit test on CI. Add changelog entry. Prebid Release 0.17.0 remove hb_pb targeting key for deal bids with no cpm (prebid#881) Fix for bug prebid#866 (prebid#867) Allow changing of 'ga' global variable (prebid#832) emit auction end event before bidsBackHandler callback (prebid#884) Add Widespace adapter (prebid#846) prevent rubicon adapter from registering two bids on exceptions (prebid#854) Code Refactoring - Upgrading end point. (prebid#826) Ignore test html pages (prebid#878) Detect browser width instead of the screen width (prebid#837) New aardvark adapter with support for aliasing (prebid#875) Add Fidelity adapter (prebid#862) Adkernel adapter aliasing (prebid#857) 0.16.1-pre
5 participants
Type of change
Description of change
index_slots.