Skip to content

Comments

add geolocation rtd provider#4607

Closed
AdmixerTech wants to merge 3 commits intoprebid:masterfrom
AdmixerTech:geolocationRTD
Closed

add geolocation rtd provider#4607
AdmixerTech wants to merge 3 commits intoprebid:masterfrom
AdmixerTech:geolocationRTD

Conversation

@AdmixerTech
Copy link
Contributor

@AdmixerTech AdmixerTech commented May 30, 2023

🏷 Type of documentation

  • new feature

📋 Checklist

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 2b5df21
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/647f0e3ebab92600088556af
😎 Deploy Preview https://deploy-preview-4607--prebid-docs-preview.netlify.app/dev-docs/modules/geolocationrtdprovider
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


## Output

For each bidder, the module adds geolocation in a JSON format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does it add this info? i.e. how would a bid adapter get access to it?

dataProviders:[{
"name": "geolocation",
"waitForIt": true,
"requestPermission": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this param? The standard for RTD modules is that module-specific params should be underneath a params object:

            dataProviders:[{          
                "name": "geolocation",
                "waitForIt": true,
                "params": {
                   "requestPermission": true
                }

@patmmccann patmmccann mentioned this pull request Jun 27, 2023
8 tasks
@bretg
Copy link
Contributor

bretg commented Jun 29, 2023

Closing as duplicate of #4680

@bretg bretg closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants