add docs for Geolocation Module#4680
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
how is this different than #4607 |
|
sorry, didn`t see it was already done |
|
Can you please close that one pull request and use this as a main |
fixed formatting and alignment, general wordsmithing
| |params | Object | | | | ||
| |params.requestPermission | Boolean | Customer permission |Required, always true | | ||
|
|
||
| The Geolocation is set in ortb2Fragments.global.device.geo in requestBidsObject and looks like this: |
There was a problem hiding this comment.
Sorry, I still don't fully understand how a bid adapter would make use of this data. I see a couple of adapters that do the following:
mergeDeep(reqBidsConfigObj.ortb2Fragments.global, _ortb2);
Is that all they need to do and the data will wind up in device.geo?
There was a problem hiding this comment.
yes, also they can get it while building request from function callback
There was a problem hiding this comment.
Cool - can you update the doc with a specific reference for how bid adapters should consume this info?
|
Hi! Can you check if everything allright? |
| } | ||
| ``` | ||
|
|
||
| It can be accessed from adapter with buildRequests` function callback of bidderRequest object. Also can be used something like mergeDeep(reqBidsConfigObj.ortb2Fragments.global, _ortb2). |
There was a problem hiding this comment.
How about this:
This data can be accessed from a bid adapter in one of several ways:
1. Read reqBidsConfigObj.ortb2Fragments.global.device.geo directly
2. Just merge everything in ortb2Fragments
3. Start utilizing the [ortbConverter library](https://github.com/prebid/Prebid.js/blob/master/libraries/ortbConverter/README.md)
Can you confirm that usage of ortbConverter will pick up the module's output?
bretg
left a comment
There was a problem hiding this comment.
thanks for your patience here. looks good
|
FYI - this docs PR will be merged after the PBJS PR is merged and released |
* Geolocation Module * markdownlint fixes * javascript spec * faq fix * fixes * fixes 2 * fixes 3 * Update activity-controls.md * Update mspa-usnat.md * Update geolocationRtdProvider.md fixed formatting and alignment, general wordsmithing * access * access 2 * lint fixes --------- Co-authored-by: bretg <bgorsline@gmail.com>
🏷 Type of documentation
📋 Checklist