Remove spack testing #221
Merged
Remove spack testing #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsimonis
requested review from
BenjaminRodenberg and
IshaanDesai
and removed request for
IshaanDesai
BenjaminRodenberg
requested changes
Sep 4, 2024
Member
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Cleaning this up makes a lot of sense. But I'm still not sure how the new process for updating the spack package will look like.
I think you also accidentally deleted some tests that we will still need.
fsimonis
force-pushed
the
remove-spack-testing
branch
from
4778351 to
fd742db
Compare
Member
Author
|
I updated this PR to only remove spack-specific things. |
fsimonis
force-pushed
the
remove-spack-testing
branch
from
fd742db to
4cee6f4
Compare
BenjaminRodenberg
approved these changes
Sep 5, 2024
Member
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Looks good 👍 Let's 💥 the spack tests.
IshaanDesai
approved these changes
Sep 5, 2024
This was referenced Mar 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the spack-related tests and documentation.
Testing the spack package is now an additional optional step in the Release Guide.
Closes #220