-
-
Notifications
You must be signed in to change notification settings - Fork 16
Test spack build using external dependencies #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems to be missing in precice spack package. See https://github.com/precice/python-bindings/runs/2014465956?check_suite_focus=true#step:8:734
…dings into spack-ci-improvements
|
I tried building the spack base image, but ran into trouble with building boost, when building locally via This needs some further investigation. |
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the spack package is not widely used. Testing how the package behaves with dependencies from the base system is probably useful but also increases cost for testing and general complexity. We can keep this PR lying around or close it. Any opinion @fsimonis ?
I took care of updating the most obvious parts and added some comments at the relevant places.
| ADD ./spack/repo /py-pyprecice-repo | ||
|
|
||
| RUN source /spack/share/spack/setup-env.sh && \ | ||
| spack --color=always external find --not-buildable && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the relevant line in this dockerfile compared to ci-spack-pyprecice-deps-2404.dockerfile
|
This PR has become irrelevant due to removal of the spack testing in #221 |
Related to #86
Todo