Update requirements of the solver dummy #233
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pyprecice~=3.0 | ||
| argparse>=1.4 | ||
| numpy>=1.16 | ||
| numpy >1, <2 |
Member
There was a problem hiding this comment.
Suggested change
| numpy >1, <2 | |
| numpy >=1.16, <2 |
Or is the 1.16 requirement not relevant?
Member
Author
There was a problem hiding this comment.
In the testing I did, and also looking at the CI, the >=1.16 requirement seems to no longer be required. But it could be relevant for older systems.
Member
There was a problem hiding this comment.
We added this requirement over 5 years ago and I'm not sure why (b1fb12b does not give this information. Looking at precice/precice@76f3acc the numpy>=1.16 seems quite arbitrary). So let's remove it. I assume that using numpy < 1.16 should not be an issue anymore and removing this details also simplifies the requirements.txt a bit. If it breaks in the future we can introduce it again.
BenjaminRodenberg
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory. Closes #232