Skip to content

Update requirements of the solver dummy #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminRodenberg merged 2 commits into from
Mar 31, 2025
Merged

Update requirements of the solver dummy #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5eacb3
Update requirements of the solver dummy
IshaanDesai Mar 31, 2025
2742e20
Add changelog entry
IshaanDesai Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog-entries/233.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Update `requirements.txt` of the solver dummy https://github.com/precice/python-bindings/pull/233
4 changes: 2 additions & 2 deletions examples/solverdummy/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pyprecice>=2.0
pyprecice~=3.0
argparse>=1.4
numpy>=1.16
numpy >1, <2
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numpy >1, <2
numpy >=1.16, <2

Or is the 1.16 requirement not relevant?

Copy link
Member Author

@IshaanDesai IshaanDesai Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the testing I did, and also looking at the CI, the >=1.16 requirement seems to no longer be required. But it could be relevant for older systems.

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added this requirement over 5 years ago and I'm not sure why (b1fb12b does not give this information. Looking at precice/precice@76f3acc the numpy>=1.16 seems quite arbitrary). So let's remove it. I assume that using numpy < 1.16 should not be an issue anymore and removing this details also simplifies the requirements.txt a bit. If it breaks in the future we can introduce it again.