-
-
Notifications
You must be signed in to change notification settings - Fork 16
Release v2.2.0.2 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release v2.2.0.2 #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply naming scheme repo-vX.X.X.X for release branch
Addition to 2407d6a
Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@in.tum.de>
Allow for `pyprecice` that are newer than 2.0.
Update requirements.txt
* Experiment with architecture proposed in https://github.com/haampie-spack/ci-example. * Add workflow for building dependencies from https://github.com/haampie-spack/ci-example. * Use spack dev-build, don't use jinja. * Build env on a weekly basis via cron job. * Do build for generic architecture x86_64. #81
* Adding error messages to check length of values and vertex id arrays provided for write commands * Adding provided and expected values in assertion statements Co-authored-by: ishaandesai <ishaandesai@gmail.com>
Member
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
BenjaminRodenberg
approved these changes
Apr 7, 2021
Member
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous review was, of course, an approval. Just pressed the wrong button. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release of python-bindings v2.2.0.2 which is compatible with preCICE v2.2.0
There are important new features:
Improve CI w.r.t spack package. Overhaul spack CI #89
Please refer to the
CHANGELOG.mdfor details