Skip to content

chore: fix ci pipeline#584

Merged
ckartik merged 2 commits intomainfrom
ckartik/update-dependencies
Jan 27, 2025
Merged

chore: fix ci pipeline#584
ckartik merged 2 commits intomainfrom
ckartik/update-dependencies

Conversation

@ckartik
Copy link
Copy Markdown
Contributor

@ckartik ckartik commented Jan 26, 2025

  • Updates to this new release that fixes the build issues
  • Adds pausable_init call for vanilla registry (seemed to be missing) @shaspitz - can you take a look at this?

@ckartik ckartik changed the title chore: commit new dependency chore: fix ci pipeline Jan 27, 2025
@ckartik ckartik requested review from Mikelle and shaspitz January 27, 2025 03:44
uint256 _slashingPayoutPeriodBlocks,
address _owner
) external initializer {
__Pausable_init();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving this to a separate change and unblock the CI first. I think this change will need vanilla registry contract upgrade which is on L1. I am not sure how to handle this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also causing the CI to fail, need to add it in or the tests compain.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with @shaspitz and he Ok'd the change here

Copy link
Copy Markdown
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the change in the vanilla registry, LGTM!

@ckartik ckartik requested a review from aloknerurkar January 27, 2025 15:45
@ckartik ckartik merged commit f9f3f18 into main Jan 27, 2025
@ckartik ckartik deleted the ckartik/update-dependencies branch January 27, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants