Skip to content

chore: fix ci pipeline #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckartik merged 2 commits into from
Jan 27, 2025
Merged

chore: fix ci pipeline #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8683cb3
chore: commit new dependency
ckartik Jan 26, 2025
bcf3d15
feat: call pausable initilaizer
ckartik Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contracts/contracts/validator-registry/VanillaRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ contract VanillaRegistry is IVanillaRegistry, VanillaRegistryStorage,
uint256 _slashingPayoutPeriodBlocks,
address _owner
) external initializer {
__Pausable_init();
Copy link
Copy Markdown
Collaborator

@aloknerurkar aloknerurkar Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving this to a separate change and unblock the CI first. I think this change will need vanilla registry contract upgrade which is on L1. I am not sure how to handle this.

Copy link
Copy Markdown
Contributor Author

@ckartik ckartik Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also causing the CI to fail, need to add it in or the tests compain.

Copy link
Copy Markdown
Contributor Author

@ckartik ckartik Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with @shaspitz and he Ok'd the change here

_setMinStake(_minStake);
_setSlashOracle(_slashOracle);
_setUnstakePeriodBlocks(_unstakePeriodBlocks);
Expand Down
2 changes: 1 addition & 1 deletion contracts/lib/openzeppelin-upgrades
Open in desktop
Submodule openzeppelin-upgrades updated 42 files
+1 −1 .github/workflows/checks.yml
+1 −1 LICENSE
+1 −1 docs/antora.yml
+3 −1 docs/modules/ROOT/pages/api-core.adoc
+14 −2 docs/modules/ROOT/pages/api-hardhat-upgrades.adoc
+30 −2 docs/modules/ROOT/pages/foundry/pages/foundry-upgrades.adoc
+14 −0 packages/core/CHANGELOG.md
+625 −0 packages/core/contracts/test/ValidationsInitializer.sol
+4 −0 packages/core/contracts/test/cli/excludes/AbstractUUPS.sol
+3 −3 packages/core/package.json
+6 −2 packages/core/src/cli/cli.test.ts.md
+ − packages/core/src/cli/cli.test.ts.snap
+4 −4 packages/core/src/cli/validate.ts
+1 −1 packages/core/src/index.ts
+5 −6 packages/core/src/utils/make-namespaced.test.ts
+54 −51 packages/core/src/utils/make-namespaced.ts
+0 −23 packages/core/src/utils/slang/trivia.ts
+224 −0 packages/core/src/validate-initializers.test.ts
+40 −15 packages/core/src/validate/overrides.ts
+24 −2 packages/core/src/validate/report.ts
+38 −2 packages/core/src/validate/run.ts
+316 −0 packages/core/src/validate/run/initializer.ts
+17 −0 packages/plugin-hardhat/CHANGELOG.md
+30 −0 packages/plugin-hardhat/contracts/AccessManagedProxy.sol
+24 −0 packages/plugin-hardhat/contracts/CustomBeaconProxy.sol
+5 −5 packages/plugin-hardhat/package.json
+6 −8 packages/plugin-hardhat/src/defender/deploy.ts
+15 −10 packages/plugin-hardhat/src/deploy-beacon-proxy.ts
+19 −12 packages/plugin-hardhat/src/deploy-contract.ts
+17 −10 packages/plugin-hardhat/src/deploy-proxy.ts
+10 −8 packages/plugin-hardhat/src/index.ts
+3 −0 packages/plugin-hardhat/src/type-extensions.ts
+11 −6 packages/plugin-hardhat/src/upgrade-proxy.ts
+5 −4 packages/plugin-hardhat/src/utils/contract-instance.ts
+7 −3 packages/plugin-hardhat/src/utils/deploy.ts
+23 −2 packages/plugin-hardhat/src/utils/options.ts
+56 −0 packages/plugin-hardhat/test/beacon-custom-beacon-proxy.js
+24 −0 packages/plugin-hardhat/test/defender-deploy.js
+53 −0 packages/plugin-hardhat/test/uups-custom-proxy.js
+1 −1 submodules/openzeppelin-foundry-upgrades
+2 −2 tsconfig.base.json
+985 −89 yarn.lock