Fix problems in MobileIDEView (#2184)#2185
Closed
lindapaiste wants to merge 14 commits intoprocessing:developfrom
Closed
Fix problems in MobileIDEView (#2184)#2185lindapaiste wants to merge 14 commits intoprocessing:developfrom
MobileIDEView (#2184)#2185lindapaiste wants to merge 14 commits intoprocessing:developfrom
Conversation
# Conflicts: # client/modules/IDE/pages/IDEView.jsx
…factor/props-drilling # Conflicts: # client/modules/IDE/components/Editor.jsx # client/modules/IDE/components/Feedback.jsx
…rilling # Conflicts: # client/modules/IDE/components/Editor.jsx # client/modules/IDE/components/Feedback.jsx # client/modules/IDE/components/Preferences/index.jsx # client/modules/IDE/components/ShareModal.jsx # client/modules/IDE/pages/IDEView.jsx
6 tasks
4 tasks
Collaborator
|
Hey, I noticed you closed #2184, so I'm going to go ahead with closing this as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon PR #2054
Progress on issue #2184
Changes:
Preferences:
MobilePreferencesis now a wrapper around the mainPreferencescontent instead of recreating it.classNameprop onPreferencesso that it can be restyled withstyled-components.Screenbe an extension of the desktopRootPage, which applies global text colors based on the current theme. So now those text colors are applied to thePreferences.PreferencePickerwhich is no longer needed."MobilePreferences"key from translations, since this data already exists in"Preferences".Navigation:
getNavOptionsinto a componentNavMenubecause it's super weird to call hooks inside a plain function.NavMenuitems (logged out and logged in) rather than repeating the shared items twice.ActionStrip.FloatingNavwhich is not used.MobileIDEView:
react-reduxhooksuseSelectoranduseDispatchinstead ofconnect.connectprops by connecting components deeper in the tree instead of props drilling.withChangeDotin theMobileIDEViewand the original lines in theEditorinto a reusableUnsavedChangesIndicatorcomponent so that it doesn't need to be repeated in both versions.IDEViewinto a new componentAutosaveHandlerwhich can be used byMobileIDEView. I'm considering this a temporary solution because I did not remove the code fromIDEViewso now we have it two places.Etc:
PreviewFrameas they don't do anything.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123