Create OnOffToggle component for preferences.#2323
Open
lindapaiste wants to merge 5 commits intoprocessing:developfrom
Open
Create OnOffToggle component for preferences.#2323lindapaiste wants to merge 5 commits intoprocessing:developfrom
OnOffToggle component for preferences.#2323lindapaiste wants to merge 5 commits intoprocessing:developfrom
Conversation
Contributor
Author
|
Maybe I should rework the |
…noff # Conflicts: # client/modules/IDE/components/Preferences/index.jsx
Contributor
Author
|
Possibly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is purely a code cleanup, there is no change to UI or behavior. It extracts a lot of repetitive code in the
Preferencescomponent into a new componentOnOffToggle.The component is inspired by @ghalestrilo's
optionsOnOffcode for the mobile preferences (which will be going away, in favor of a single responsive component).It will probably evolve more as I refactor other parts of the Preferences.
Changes:
OnOffTogglefor the clickable "On" and "Off" labels.OnOffToggleinPreferencesfor Autosave, Autoclose Brackets and Quotes, etc.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123