Failure to construct p5 in instance mode when using custom bundles (combineModules)

[hsab]

When creating a custom bundle using combineModules, p5 fails to instantiate with the error:
p5 is not a constructor

Nature of issue?

• Found a bug

Most appropriate sub-area of p5.js?

• Build system

Which platform were you using when you encountered this?

• Desktop/Laptop

Details about the bug:

• p5.js version: 99252b9
• Web browser and version: Chrome 75.0.3770.100
• Steps to reproduce this:
  npm run grunt combineModules:core/shape:color:math:image
  Use the following for sketch.js in emptyExample

  const s = ( sketch ) => {
  
    let x = 100;
    let y = 100;
  
    sketch.setup = () => {
      sketch.createCanvas(200, 200);
    };
  
    sketch.draw = () => {
      sketch.background(0);
      sketch.fill(255);
      sketch.rect(x,y,50,50);
    };
  };
  
  let myp5 = new p5(s);
  

  Results in error p5 is not a constructor

[hsab]

@outofambit any idea why this happens? I assume there are steps in the regular build process that are not included in combineModules. Is this a correct assumption?

[limzykenneth]

@hsab It may be the browserify step not exposing a p5 global on the combine module step

[outofambit]

@hsab @limzykenneth yep that's my theory too. i think there also might be an error that happens if the final export of p5 from the bundle doesn't use the old school way of exporting. (i think it confuses browserify somehow?)

i believe that's why app.js uses this:

p5.js/src/app.js

Line 87 in 5df69d9

module.exports = p5;

ah yes, that's what @hsab figured out in #3758 (comment)!

[hsab]

@sakshamsaxena thanks for following up on this.

[sakshamsaxena]

#4211 is up now, should fix this for once and all