Skip to content

Comments

Fixed broken building task of combineModules#4211

Merged
lmccart merged 2 commits intoprocessing:masterfrom
sakshamsaxena:meta/fix
Dec 27, 2019
Merged

Fixed broken building task of combineModules#4211
lmccart merged 2 commits intoprocessing:masterfrom
sakshamsaxena:meta/fix

Conversation

@sakshamsaxena
Copy link
Contributor

@sakshamsaxena sakshamsaxena commented Dec 27, 2019

Resolves #3883

Changes:

  • Updated the logic to generate custom build by creating a clone of app.js temporarily but with only the required modules mentioned as imports. This had to be done so as to introduce a single file entry point for bundling, as otherwise the p5 class was not exported as it should, and its bindings were lost.

PR Checklist

@lmccart
Copy link
Member

lmccart commented Dec 27, 2019

thanks @sakshamsaxena!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to construct p5 in instance mode when using custom bundles (combineModules)

2 participants