Use "most" instead of "more", in singular for clarity and consistency#668
Closed
fluorine wants to merge 1 commit intoprogit:masterfrom
fluorine:master
Closed
Use "most" instead of "more", in singular for clarity and consistency#668fluorine wants to merge 1 commit intoprogit:masterfrom fluorine:master
fluorine wants to merge 1 commit intoprogit:masterfrom
fluorine:master
Conversation
fluorine
changed the title
Frezzle
reviewed
Oct 17, 2016
| .Local version control. | ||
| image::images/local.png[Local version control diagram] | ||
|
|
||
| One of the more popular VCS tools was a system called RCS, which is still distributed with many computers today. |
Contributor
There was a problem hiding this comment.
If using most here then tool is wrong; tools is still correct. Some suggestions:
One of the most popular VCS tools was...The most popular VCS tool was...
Member
There was a problem hiding this comment.
Came here to say this exact thing. Let's go with "…most popular VCS tools…"
chiara35
approved these changes
Dec 14, 2016
ben
requested changes
Dec 14, 2016
| image::images/local.png[Local version control diagram] | ||
|
|
||
| One of the more popular VCS tools was a system called RCS, which is still distributed with many computers today. | ||
| One of the most popular VCS tool was a system called RCS, which is still distributed with many computers today. |
Member
There was a problem hiding this comment.
Unfortunately now we have a disagreement. This should read "One of the most popular VCS tools …"
chiara35
approved these changes
Dec 15, 2016
Contributor
|
@ben I propose to make the correction myself and close this pull request. Do you agree? |
Member
|
Sure, go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.