Skip to content

Use "most" instead of "more", in singular for clarity and consistency #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fluorine wants to merge 1 commit into from
Closed

Use "most" instead of "more", in singular for clarity and consistency #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/01-introduction/sections/about-version-control.asc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ To deal with this issue, programmers long ago developed local VCSs that had a si
.Local version control.
image::images/local.png[Local version control diagram]

One of the more popular VCS tools was a system called RCS, which is still distributed with many computers today.
One of the most popular VCS tool was a system called RCS, which is still distributed with many computers today.
Copy link
Contributor

@Frezzle Frezzle Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using most here then tool is wrong; tools is still correct. Some suggestions:

  • One of the most popular VCS tools was...
  • The most popular VCS tool was...

Copy link
Member

@ben ben Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came here to say this exact thing. Let's go with "…most popular VCS tools…"

Copy link
Author

@fluorine fluorine Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

Copy link
Member

@ben ben Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately now we have a disagreement. This should read "One of the most popular VCS tools …"

Even the popular Mac OS X operating system includes the `rcs` command when you install the Developer Tools.
RCS works by keeping patch sets (that is, the differences between files) in a special format on disk; it can then re-create what any file looked like at any point in time by adding up all the patches.

Expand Down