fix(bind): interpret bind defined as type []map[string]string

[darshilgit]

As per the type definition of Layer, bind is of type Bind which is a
struct with fields Source and Dest.

But when we do UnmarshalYAML for type Bind, we are assuming that we
would always get the Bind as a []string and not
[]map[interface{}]interface{} (when making a call to
getStringOrStringSlice).

This PR fixes the getStringOrStringSlice to consider Bind defined
as a []map[string]string and returns appropriate bind string
in that case.

Fixes #301

[mikemccracken]

LGTM, let's add a test case for this

…

On Thu, Jun 16, 2022 at 1:36 AM Darshil Parikh ***@***.***> wrote: Fixes #301 <#301> ------------------------------ You can view, comment on, or merge this pull request online at: #302 Commit Summary - 96f90bb <96f90bb> interpret Bind as well when getting string or slice from interface{} File Changes (1 file <https://github.com/project-stacker/stacker/pull/302/files>) - *M* types/layer.go <https://github.com/project-stacker/stacker/pull/302/files#diff-aef8927a5078ca12d21f08d41d782696bd2db2502bcef3fe05ed41f3edb3e2e0> (9) Patch Links: - https://github.com/project-stacker/stacker/pull/302.patch - https://github.com/project-stacker/stacker/pull/302.diff — Reply to this email directly, view it on GitHub <#302>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANPVKU4H36AZVOAMZZGBWDVPJSIBANCNFSM5Y47DCLQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mikemccracken]

Since we're just adding a simple syntax test that the struct syntax for binds works, how about moving this to a new file test/binds.bats, and add a simplified test for the old syntax too?

[hallyn]

@darshilgit can you rebase and repush to retrigger build? (the build logs have been purged)

[rchincha]

I might need this in PR #349

[hallyn]

Thank you

[rchincha]

Not particularly happy with that we are turning golang to loosey-goosey javascript here, but a cleanup for another day.