feat: add a "stacker convert" to convert a Dockerfile by rchincha · Pull Request #349 · project-stacker/stacker

rchincha · 2022-12-05T22:59:37Z

https://docs.docker.com/engine/reference/builder/

`
stacker help convert

help convert
NAME:
stacker-dynamic convert - converts a Dockerfile into a stacker yaml
file

USAGE:
stacker-dynamic convert [command options] [arguments...]

OPTIONS:
--Dockerfile value, -f value the input Dockerfile (default: "Dockerfile")
`

Signed-off-by: Ramkumar Chinchani rchincha@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rchincha · 2022-12-09T21:22:31Z

Surprisingly, breaks here

not ok 30 bind rebuilds

(in test file test/caching.bats, line 151)

`out=$(stacker build --substitute bind_path=${bind_path} --substitute CENTOS_OCI=$CENTOS_OCI)' failed

rchincha · 2022-12-09T21:22:53Z

and not here:
ok 41 convert a Dockerfile

rchincha · 2022-12-24T05:25:08Z

Lookup2: name:bind-test cache:map[]

TEST (binds): 1 [{/home/runner/work/stacker/stacker/stackertest-test_bind_rebuilds.78LQ7s/tree2/foo /root/tree2/foo}] hit: false

rchincha · 2023-01-09T01:47:36Z

alpine/edge gcc was updated with this recently.
https://git.alpinelinux.org/aports/commit/?id=4592d806b9c8832895c32aeb53936b345b04b500

Fails spectacularly ...
/usr/lib/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
lto-wrapper: warning: Extra option to '-Xassembler': --noexecstack, dropping all '-Xassembler' and '-Wa' options.
during IPA pass: static-var
lto1: internal compiler error: original not compressed with zstd
0x18df117 internal_error(char const*, ...)
???:0
0x9d23da lto_end_uncompression(lto_compression_stream*, lto_compression)
???:0
0x9d09a0 lto_get_section_data(lto_file_decl_data*, lto_section_type, char const*, int, unsigned long*, bool)
???:0
0x94ae28 symbol_table::remove_unreachable_nodes(_IO_FILE*)
???:0
0x68e897 read_cgraph_and_symbols(unsigned int, char const**)
???:0
0x67ab02 lto_main()
???:0
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See https://gitlab.alpinelinux.org/alpine/aports/-/issues for instructions.

rchincha · 2023-01-09T01:57:35Z

https://gitlab.alpinelinux.org/alpine/aports/-/issues/14537

hallyn

Looks good, just a few questions below.

go.mod

cmd/stacker/publish.go

pkg/types/layer.go

Start with a subset of Dockerfile grammar. (syntax version 1) """ stacker help convert help convert NAME: stacker-dynamic convert - converts a Dockerfile into a stacker yaml file USAGE: stacker-dynamic convert [command options] [arguments...] OPTIONS: --docker-file value, -i value the input Dockerfile (default: "Dockerfile") --output-file value, -o value the output stacker file (default: "stacker.yaml") --substitute-file value, -s value the output file containing detected substitutions (default: "stacker-subs.yaml") """ Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

rchincha force-pushed the dockerfile branch 12 times, most recently from 61ad5c4 to 7df4544 Compare December 9, 2022 18:51

rchincha marked this pull request as ready for review December 9, 2022 19:04

rchincha requested review from hallyn and smoser as code owners December 9, 2022 19:04

rchincha force-pushed the dockerfile branch from 7df4544 to 5383290 Compare December 9, 2022 19:30

rchincha force-pushed the dockerfile branch from 5383290 to 060ba84 Compare December 9, 2022 21:23

rchincha mentioned this pull request Dec 14, 2022

fix(bind): interpret bind defined as type []map[string]string #302

Merged

rchincha force-pushed the dockerfile branch from 060ba84 to 822b18b Compare December 14, 2022 23:10

rchincha added this to the v0.40.2 milestone Dec 16, 2022

rchincha force-pushed the dockerfile branch 6 times, most recently from 552fbff to 21f724c Compare December 21, 2022 21:27

rchincha changed the title ~~feat: add a "stacker convert" to convert a Dockerfile~~ feat: add a "stacker convert" to convert a Dockerfile - DON'T MERGE Dec 21, 2022

rchincha force-pushed the dockerfile branch from 21f724c to 61d6f22 Compare December 22, 2022 04:09

rchincha force-pushed the dockerfile branch 3 times, most recently from 4b5c4b2 to 6bde6ab Compare December 24, 2022 00:28

rchincha force-pushed the dockerfile branch 5 times, most recently from 4a7bb17 to 78da872 Compare December 26, 2022 04:01

rchincha force-pushed the dockerfile branch 8 times, most recently from 5077952 to dfde64f Compare January 7, 2023 23:31

rchincha force-pushed the dockerfile branch from adc99d6 to 7f943a1 Compare January 8, 2023 23:49

rchincha changed the title ~~feat: add a "stacker convert" to convert a Dockerfile - DON'T MERGE~~ feat: add a "stacker convert" to convert a Dockerfile Jan 8, 2023

rchincha force-pushed the dockerfile branch 2 times, most recently from 4fe2bb9 to 352bec5 Compare January 9, 2023 01:41

hallyn approved these changes Jan 9, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

cmd/stacker/publish.go Show resolved Hide resolved

pkg/types/layer.go Show resolved Hide resolved

rchincha force-pushed the dockerfile branch 2 times, most recently from 04a1d7f to 6861dee Compare January 9, 2023 19:59

Ramkumar Chinchani added 2 commits January 9, 2023 21:11

feat: add "substitute-file" support for publish cmd

31d1e68

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

rchincha force-pushed the dockerfile branch from 6861dee to 31d1e68 Compare January 9, 2023 21:12

rchincha merged commit c00511a into project-stacker:main Jan 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add a "stacker convert" to convert a Dockerfile#349

feat: add a "stacker convert" to convert a Dockerfile#349
rchincha merged 2 commits intoproject-stacker:mainfrom
rchincha:dockerfile

rchincha commented Dec 5, 2022 •

edited

Loading

Uh oh!

rchincha commented Dec 9, 2022

Uh oh!

rchincha commented Dec 9, 2022

Uh oh!

rchincha commented Dec 24, 2022

Uh oh!

rchincha commented Jan 9, 2023 •

edited

Loading

Uh oh!

rchincha commented Jan 9, 2023

Uh oh!

hallyn left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

rchincha commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rchincha commented Dec 9, 2022

(in test file test/caching.bats, line 151)

`out=$(stacker build --substitute bind_path=${bind_path} --substitute CENTOS_OCI=$CENTOS_OCI)' failed

Uh oh!

rchincha commented Dec 9, 2022

Uh oh!

rchincha commented Dec 24, 2022

Lookup2: name:bind-test cache:map[]

TEST (binds): 1 [{/home/runner/work/stacker/stacker/stackertest-test_bind_rebuilds.78LQ7s/tree2/foo /root/tree2/foo}] hit: false

Uh oh!

rchincha commented Jan 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rchincha commented Jan 9, 2023

Uh oh!

hallyn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

rchincha commented Dec 5, 2022 •

edited

Loading

rchincha commented Jan 9, 2023 •

edited

Loading