Skip to content

Provide default working config for artifacts#1313

Merged
stuartnelson3 merged 1 commit intomasterfrom
stn/working-default-config
Apr 5, 2018
Merged

Provide default working config for artifacts#1313
stuartnelson3 merged 1 commit intomasterfrom
stn/working-default-config

Conversation

@stuartnelson3
Copy link
Contributor

Fixes #484

@brian-brazil
Copy link
Contributor

👍

@stuartnelson3 stuartnelson3 merged commit b1625a0 into master Apr 5, 2018
@stuartnelson3 stuartnelson3 deleted the stn/working-default-config branch April 5, 2018 14:25
mxinden pushed a commit to mxinden/alertmanager that referenced this pull request May 5, 2018
@mxinden
Copy link
Member

mxinden commented Jun 25, 2018

@stuartnelson3 @brian-brazil What is the reasoning for changing WORKDIR from /alertmanager to /etc/alertmanager? Prometheus uses /prometheus. I would expect etc for configuration files, but not for alerting data. If not /alertmanager, maybe /var/alertmanager?

This came up here: #1433

@mxinden
Copy link
Member

mxinden commented Jun 25, 2018

@discordianfish
Copy link
Member

Yeah that broke our setup too. It's also not mentioned in the changelog.

@mxinden
Copy link
Member

mxinden commented Jun 29, 2018

@discordianfish yes, sorry about the missing changelog entry. I fixed that and updated CHANGELOG.md in both release and master branch.

Once @stuartnelson3 is back, he can probably give us more details here for the initial change.

@stuartnelson3
Copy link
Contributor Author

A bit sheepishly, I admit that changing the WORKDIR was so that I didn't have to add the --config.file flag to the invocation. Feel free to change it back, just remember to specify the config location.

@stuartnelson3
Copy link
Contributor Author

@mxinden ^

@mxinden
Copy link
Member

mxinden commented Jul 4, 2018

@stuartnelson3 ok. Let's move this discussion to #1435 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants