fix: reverted change of dockerfile entrypoint#1435
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom Jul 4, 2018
Merged
fix: reverted change of dockerfile entrypoint#1435stuartnelson3 merged 1 commit intoprometheus:masterfrom
stuartnelson3 merged 1 commit intoprometheus:masterfrom
Conversation
mxinden
approved these changes
Jul 4, 2018
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
This looks good to me.
Would you mind adding a section on top of the top level CHANGELOG.md in this PR so we make sure to include the breaking change notice in the next release?
## Next release
* [CHANGE] Revert Alertmanager working directory changes in Docker image back to `/alertmanager` (#1435)
@stuartnelson3 anything missing here?
gabreal
pushed a commit
to paritytech/alertmanager
that referenced
this pull request
Jul 31, 2018
gabreal
pushed a commit
to paritytech/alertmanager
that referenced
this pull request
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1433
This PR fixes breaking change in chande in dockerfile WORKDIR.
Since
0.15.0if user overridden thecmdand did not specify thestorage.pathdata were stored by default to/etc/alertmanager/data