Enable support for custom callbacks as part of maintenance#2689
Merged
codesome merged 6 commits intoprometheus:mainfrom Sep 6, 2021
Merged
Enable support for custom callbacks as part of maintenance#2689codesome merged 6 commits intoprometheus:mainfrom
codesome merged 6 commits intoprometheus:mainfrom
Conversation
This enables support for custom Maintenance callbacks as part of the periodic maintenance of silences and notification logs. Effectively a no-op for the Alertmanager but allows downstream implementation to inject custom logic as part of it. Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
force-pushed
the
allow-custom-functions-for-maintenance
branch
from
6dc913f to
641eb2d
Compare
Member
|
Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
force-pushed
the
allow-custom-functions-for-maintenance
branch
from
5819fc5 to
2db75f7
Compare
gouthamve
reviewed
Sep 2, 2021
Member
gouthamve
left a comment
gouthamve
left a comment
There was a problem hiding this comment.
Looks good, but omg the code is hard to grok due to the small variable names. Can we make that better and document in the function comment that this new parameter is optional and advanced usage?
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
force-pushed
the
allow-custom-functions-for-maintenance
branch
from
4f1a7e4 to
cdfbc2b
Compare
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Closed
5 tasks
juliusv
added a commit
that referenced
this pull request
Sep 13, 2021
#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com>
Member
|
This introduced a crash bug for the default silence maintenance function, see fix in #2701. |
codesome
pushed a commit
that referenced
this pull request
Sep 13, 2021
#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com>
3 tasks
nekketsuuu
pushed a commit
to nekketsuuu/alertmanager
that referenced
this pull request
Oct 1, 2021
…s#2689) * Enable support for custom callbacks as part of maintenance This enables support for custom Maintenance callbacks as part of the periodic maintenance of silences and notification logs. Effectively a no-op for the Alertmanager but allows downstream implementation to inject custom logic as part of it. Signed-off-by: gotjosh <josue.abreu@gmail.com> * Add tests Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix tests and remove whitespace Signed-off-by: gotjosh <josue.abreu@gmail.com> * Address review comments Signed-off-by: gotjosh <josue.abreu@gmail.com> * run go fmt Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix import ordering Signed-off-by: gotjosh <josue.abreu@gmail.com>
nekketsuuu
pushed a commit
to nekketsuuu/alertmanager
that referenced
this pull request
Oct 1, 2021
prometheus#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
…s#2689) * Enable support for custom callbacks as part of maintenance This enables support for custom Maintenance callbacks as part of the periodic maintenance of silences and notification logs. Effectively a no-op for the Alertmanager but allows downstream implementation to inject custom logic as part of it. Signed-off-by: gotjosh <josue.abreu@gmail.com> * Add tests Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix tests and remove whitespace Signed-off-by: gotjosh <josue.abreu@gmail.com> * Address review comments Signed-off-by: gotjosh <josue.abreu@gmail.com> * run go fmt Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix import ordering Signed-off-by: gotjosh <josue.abreu@gmail.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
prometheus#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
…s#2689) * Enable support for custom callbacks as part of maintenance This enables support for custom Maintenance callbacks as part of the periodic maintenance of silences and notification logs. Effectively a no-op for the Alertmanager but allows downstream implementation to inject custom logic as part of it. Signed-off-by: gotjosh <josue.abreu@gmail.com> * Add tests Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix tests and remove whitespace Signed-off-by: gotjosh <josue.abreu@gmail.com> * Address review comments Signed-off-by: gotjosh <josue.abreu@gmail.com> * run go fmt Signed-off-by: gotjosh <josue.abreu@gmail.com> * Fix import ordering Signed-off-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
prometheus#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables support for custom Maintenance callbacks as part of the periodic maintenance of silences and notification logs.
Effectively a no-op for the Alertmanager but allows a downstream implementation to inject custom logic as part of it.