Correctly call default silence maintenance function#2701
Merged
Conversation
#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com>
1 task
Member
|
Thanks for picking this up @juliusv. |
Member
|
Looks like it did not hit a stable release. |
Member
Author
|
Yep, luckily not, all good :) |
3 tasks
nekketsuuu
pushed a commit
to nekketsuuu/alertmanager
that referenced
this pull request
Oct 1, 2021
prometheus#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
prometheus#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
prometheus#2689 introduced a regression where the default maintenance function would no longer be called even if no override was specified. The Alertmanager now crashes on any silence maintenance run without this fix. Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2689 introduced a
regression where the default maintenance function would no longer be
called even if no override was specified. The Alertmanager now crashes
on any silence maintenance run without this fix.
Signed-off-by: Julius Volz julius.volz@gmail.com