Merged
Conversation
gotjosh
force-pushed
the
webex-notifier
branch
from
e7143a2 to
e176a65
Compare
alexweav
approved these changes
Nov 8, 2022
Contributor
alexweav
left a comment
alexweav
left a comment
There was a problem hiding this comment.
Looking good, a couple very small nits
gotjosh
added a commit
that referenced
this pull request
Nov 9, 2022
While most integrations set a limit by UTF-8 compatible characters (some like Webex) use runes - as pointed out in #3132. This PR makes it explicit wether the truncation is happening at a byte or rune level.
gotjosh
added a commit
that referenced
this pull request
Nov 9, 2022
While most integrations set a limit by UTF-8 compatible characters (some like Webex) use runes - as pointed out in #3132. This PR makes it explicit wether the truncation is happening at a byte or rune level. Signed-off-by: gotjosh <josue.abreu@gmail.com>
Cisco's Webex has been one of the most requested notifiers on Grafana for a while now, please see: grafana/grafana#11750 (comment) Given it's straightforward implementation, low maintance overhead and request demand, I think it's worth including this directly in the Alertmanager. Signed-off-by: gotjosh <josue.abreu@gmail.com>
…tup in Webex Teams - Move away from Webhook to APIRUL - Make the Room ID a require field - Set Authorization Credentails via Headers Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
…present Signed-off-by: gotjosh <josue.abreu@gmail.com>
…utchered Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
force-pushed
the
webex-notifier
branch
from
628312e to
f51f51e
Compare
3 tasks
rabellamy
reviewed
Nov 11, 2022
Signed-off-by: gotjosh <josue.abreu@gmail.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Nov 16, 2022
While most integrations set a limit by UTF-8 compatible characters (some like Webex) use runes - as pointed out in prometheus#3132. This PR makes it explicit wether the truncation is happening at a byte or rune level. Signed-off-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
alexweav
approved these changes
Nov 25, 2022
Member
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
Looks good! I have a comment on the configuration + we would need an addition to https://github.com/prometheus/alertmanager/blob/main/docs/configuration.md#receiver.
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
While most integrations set a limit by UTF-8 compatible characters (some like Webex) use runes - as pointed out in prometheus#3132. This PR makes it explicit wether the truncation is happening at a byte or rune level. Signed-off-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Merged
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Member
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
lgtm, albeit 2 minor comments on the doc part.
Signed-off-by: gotjosh <josue.abreu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cisco's Webex has been one of the most requested notifiers on Grafana for a while now, please see: grafana/grafana#11750 (comment)
Given it's straightforward implementation, low maintenance overhead and request demand, I think it's worth including this directly in the Alertmanager.