Merged
Conversation
Member
|
I'll address your comments shortly! |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
v0.25.0-rc.0
branch
from
19c620e to
eabf1a0
Compare
roidelapluie
approved these changes
Dec 16, 2022
simonpasquier
force-pushed
the
v0.25.0-rc.0
branch
from
eabf1a0 to
6fb99d3
Compare
gotjosh
approved these changes
Dec 16, 2022
Member
gotjosh
left a comment
gotjosh
left a comment
There was a problem hiding this comment.
LGTM, but please see my comments.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
v0.25.0-rc.0
branch
from
6fb99d3 to
5bfd61d
Compare
gotjosh
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gotjosh I know you have #3132 pending. Do you think that you have time to address my comments or can it wait for the next minor Alertmanager release?