Changes receiver and inhibition rules arrays to slices of value items instead of pointer items#3209
Merged
simonpasquier merged 1 commit intoprometheus:mainfrom Jan 19, 2023
Conversation
rohang98
force-pushed
the
pointer-to-value-fix
branch
2 times, most recently
from
516115d to
bd17255
Compare
Contributor
Author
|
@simonpasquier could you please take a look whenever you get the chance! |
Member
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
lgtm, the test failures are unrelated to your change and investigated in #3216
| at.Run() | ||
| } | ||
|
|
||
| func TestEmptyInhibitionRule(t *testing.T) { |
Member
There was a problem hiding this comment.
We can keep only the test in test/with_api_v2/acceptance since it's irrespective of the API versions.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! Removed the test.
rohang98
force-pushed
the
pointer-to-value-fix
branch
from
bd17255 to
7772afb
Compare
Member
|
could you rebase on top of |
Signed-off-by: Rohan Gupta <rohangupta.0927@gmail.com>
rohang98
force-pushed
the
pointer-to-value-fix
branch
from
7772afb to
df1dc0d
Compare
Contributor
Author
|
@simonpasquier looks like the tests all pass now. |
simonpasquier
approved these changes
Jan 19, 2023
Member
|
thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent panics caused by null-pointer exceptions for empty array objects, I used @simonpasquier's suggestion by changing the arrays to slices of value items instead of pointer items.
Fixes #3204