fix: change receiver model pointer to value#3338
Merged
gotjosh merged 2 commits intoprometheus:mainfrom Apr 28, 2023
Merged
Conversation
fgouteroux
force-pushed
the
fix-api-v2-receivers
branch
3 times, most recently
from
9e28e3d to
d14eb77
Compare
gotjosh
requested changes
Apr 28, 2023
Member
gotjosh
left a comment
gotjosh
left a comment
There was a problem hiding this comment.
Thanks! Please see my comment.
gotjosh
added
the
waiting-for-user-input
fgouteroux
force-pushed
the
fix-api-v2-receivers
branch
2 times, most recently
from
e739162 to
59fcf78
Compare
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
fgouteroux
force-pushed
the
fix-api-v2-receivers
branch
from
59fcf78 to
775e94a
Compare
simonpasquier
approved these changes
Apr 28, 2023
gotjosh
approved these changes
Apr 28, 2023
Member
gotjosh
left a comment
gotjosh
left a comment
There was a problem hiding this comment.
LGTM
I just have one small nit, can you please address it really quickly? 😄
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Member
|
Thank you very much for your contribution! |
Contributor
Author
|
Thanks for your review ! Happy to make my 1rst contribution ! |
gotjosh
pushed a commit
that referenced
this pull request
Aug 7, 2023
* fix: change receiver pointer to value and add test Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com> --------- Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
* fix: change receiver pointer to value and add test Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com> --------- Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
There is a bug when calling
/api/v2/receivers, it return the same receiver name multiple times.Expected:
Got:
I think it was related to this change #3209.