Add .get() to Family hashmap wrapper#130
Closed
JaydenElliott wants to merge 1 commit intoprometheus:masterfrom
Closed
Add .get() to Family hashmap wrapper#130JaydenElliott wants to merge 1 commit intoprometheus:masterfrom
JaydenElliott wants to merge 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: jaydenelliott <jayden.elliott@outlook.com>
Member
|
Thanks for the pull request. In order for me to better understand the feature request, mind expanding on your concrete use-cases for this method? |
Author
|
#131 (comment) describes the use case (allows me to access the metrics of a family to do comparisons against, or use to trigger logic without modifying the underlying data structure). |
Contributor
|
this was done in #234, i believe this can be closed now. |
Member
|
You are right. Thanks @cratelyn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have come across a few instances were I would like to check if a particular metric exists in the metric
Familywithout creating a new entry if it doesn't. This PR simply exposes theHashMap::get()function to allow formatch metric_family.get()type logic.Let me know if there is anything else needed to get this change merged.