feat(metrics/family): add get method to Family#234
Merged
mxinden merged 2 commits intoprometheus:masterfrom Dec 3, 2024
Merged
feat(metrics/family): add get method to Family#234mxinden merged 2 commits intoprometheus:masterfrom
get method to Family#234mxinden merged 2 commits intoprometheus:masterfrom
Conversation
Contributor
Author
|
@mxinden PTAL, thanks! |
Contributor
|
seconding this addition, i would also suppport this change, and would like have the ability to avoid creating new metrics in a family when looking up the series for a particular label set. i'll cross-reference #244, which also introduces a new accessor to |
mxinden
reviewed
Nov 28, 2024
Member
mxinden
left a comment
There was a problem hiding this comment.
Thank you for the thorough patch.
What do you think of replacing the code below in Family::get_or_create with a call to Family::get?
if let Ok(metric) =
RwLockReadGuard::try_map(self.metrics.read(), |metrics| metrics.get(label_set))
{
return metric;
}
Also, please add a changelog entry.
Signed-off-by: Wenbo Zhang <wenbo.zhang@iomesh.com>
Signed-off-by: Wenbo Zhang <wenbo.zhang@iomesh.com>
Contributor
Author
|
@mxinden Addressed, PTAL, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address comments in #230 (comment)