Add missing tests for some 32-bit types that already work in metrics#215
Merged
mxinden merged 2 commits intoprometheus:masterfrom Jul 17, 2024
Merged
Add missing tests for some 32-bit types that already work in metrics#215mxinden merged 2 commits intoprometheus:masterfrom
mxinden merged 2 commits intoprometheus:masterfrom
Conversation
Signed-off-by: Léo Gillot-Lamure <leo.gillot@navaati.net>
Contributor
Author
|
|
navaati
changed the title
navaati
changed the title
Signed-off-by: Léo Gillot-Lamure <leo.gillot@navaati.net>
Contributor
Author
|
I don’t think changelog edit is required for just adding tests. |
Contributor
Author
|
@mxinden small easy PR, pls review ! |
mxinden
approved these changes
Jul 17, 2024
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
🙏 thanks! More tests is always appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for the new capabilities enabled by #173.