Add support of f32 for Gauge and Counter#216
Merged
mxinden merged 6 commits intoprometheus:masterfrom Jul 17, 2024
Merged
Conversation
Contributor
Author
|
Still gotta edit the changelog. |
8 tasks
Signed-off-by: Léo Gillot-Lamure <leo.gillot@navaati.net>
Signed-off-by: Léo Gillot-Lamure <leo.gillot@navaati.net>
Signed-off-by: Léo Gillot-Lamure <leo.gillot@navaati.net>
Signed-off-by: Léo Gillot-Lamure <leo.gillot@navaati.net>
Contributor
Author
mxinden
approved these changes
Jul 17, 2024
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Good work. Atomics code looks fine.
Shall we hold off with a release for now?
Comment on lines
+9
to
+25
| ### Changed | ||
|
|
||
| - `ConstCounter::new` now requires specifying the type of literal arguments, like this: `ConstCounter::new(42u64);`. | ||
| See [PR 173]. | ||
|
|
||
| - Update `prost` dependencies to `v0.12`. | ||
| See [PR 198]. | ||
|
|
||
| [PR 198]: https://github.com/prometheus/client_rust/pull/198 | ||
|
|
||
| - Add `EncodeGaugeValue` `i32` and `f32`, `EncodeCounterValue` `u32` and `f32` and `EncodeExemplarValue` `f32` and `u32` implementations. | ||
| See [PR 173]. | ||
| ### Added | ||
|
|
||
| - Support `i32`/`f32` for `Gauge` and `u32`/`f32` for `Counter`/`CounterWithExemplar`. | ||
| See [PR 173] and [PR 216]. | ||
|
|
||
| [PR 173]: https://github.com/prometheus/client_rust/pull/173 | ||
| [PR 216]: https://github.com/prometheus/client_rust/pull/216 |
Signed-off-by: Max Inden <mail@max-inden.de>
mxinden
reviewed
Jul 17, 2024
Signed-off-by: Max Inden <mail@max-inden.de>
Contributor
Author
If you have enough content for a release, go for it: the sooner you get it in the wild, the sooner you’ll have feedback if there is a problem (not that I think there would)… It’s a breaking release anyway so nobody will get broken on a As for myself I’m happy when I can remove this line https://gitlab.com/navaati/licorne/-/blob/f26f4141c357b41aae2f1235f8fe0cb3bc7af638/firmware/Cargo.toml#L42 :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.